# [PATCH] submodule: mark a file-local symbol as static

2 messages from 2016-08-14 to 2016-08-15. Participants: Ramsay Jones, Stefan Beller.
Thread: https://gitlist.dev/t/43839

## Ramsay Jones, 2016-08-13 14:31

Subject: [PATCH] submodule: mark a file-local symbol as static
Message-ID: <a44793c6-6510-9b62-d5f4-60324a062164@ramsayjones.plus.com>
URL: https://gitlist.dev/e/a44793c6-6510-9b62-d5f4-60324a062164%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Stefan,

If you need to re-roll your 'sb/submodule-clone-rr' branch, could
you please squash this into the relevant patch (commit 7bcd1d17,
"clone: recursive and reference option triggers submodule alternates",
11-08-2016).

Thanks!

[What, deja vu? :-D]

ATB,
Ramsay Jones

 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index c617667..cb0b1d7 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -483,7 +483,7 @@ struct submodule_alternate_setup {
 #define SUBMODULE_ALTERNATE_SETUP_INIT { NULL, \
 	SUBMODULE_ALTERNATE_ERROR_IGNORE, NULL }
 
-int add_possible_reference_from_superproject(
+static int add_possible_reference_from_superproject(
 		struct alternate_object_database *alt, void *sas_cb)
 {
 	struct submodule_alternate_setup *sas = sas_cb;
-- 
2.9.0

```

## Stefan Beller, 2016-08-15 19:07

Subject: Re: [PATCH] submodule: mark a file-local symbol as static
Message-ID: <CAGZ79kbsyjgPnZuCBrivYUN-tYoDNkT9VKrwXC8=C9UoorCtLw@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kbsyjgPnZuCBrivYUN-tYoDNkT9VKrwXC8%3DC9UoorCtLw%40mail.gmail.com
In-Reply-To: <a44793c6-6510-9b62-d5f4-60324a062164@ramsayjones.plus.com>

```
On Sat, Aug 13, 2016 at 7:31 AM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-clone-rr' branch, could
> you please squash this into the relevant patch (commit 7bcd1d17,
> "clone: recursive and reference option triggers submodule alternates",
> 11-08-2016).
>
> Thanks!

Thanks,

will be fixed in a reroll.

```
