threads / patch / 43713

patchsubmodule: mark a file-local symbol as static

Subject: [PATCH] submodule: mark a file-local symbol as static

## tl;dr

2 messages between Aug 11, 2016 and Aug 11, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Aug 11, 2016, 19:57 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Stefan,

If you need to re-roll your 'sb/submodule-clone-rr' branch, could you please squash this into the relevant patch (commit 336c21d, "submodule: try alternates when superproject has an alternate", 08-08-2016).

Thanks!

ATB, Ramsay Jones

 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/submodule--helper.c +1 −1

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 4c765e1..4c7d03c 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -641,7 +641,7 @@ struct submodule_alternate_setup {
 	struct strbuf *out;
 };
 
-int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
+static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
 {
 	struct submodule_alternate_setup *sas = sas_cb;

-- 
2.9.0

Stefan Beller· Aug 11, 2016, 20:13 UTC · re: Ramsay Jones · lore

Re: [PATCH] submodule: mark a file-local symbol as static

On Thu, Aug 11, 2016 at 12:57 PM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 10 quoted lines

>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-clone-rr' branch, could
> you please squash this into the relevant patch (commit 336c21d,
> "submodule: try alternates when superproject has an alternate",
> 08-08-2016).

Not just reroll but rethink and rewrite. ;)

Thanks for catching! Stefan

Show 24 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 4c765e1..4c7d03c 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -641,7 +641,7 @@ struct submodule_alternate_setup {
>         struct strbuf *out;
>  };
>
> -int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
> +static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)
>  {
>         struct submodule_alternate_setup *sas = sas_cb;
>
> --
> 2.9.0