{"thread":{"id":"43713","subject":"[PATCH] submodule: mark a file-local symbol as static","startedAt":"2016-08-11T20:20:21Z","lastAt":"2016-08-11T20:48:28Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"297219","messageId":"322d7d47-423c-f631-3057-1feb03d50591@ramsayjones.plus.com","threadId":"43713","inReplyTo":null,"subject":"[PATCH] submodule: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-08-11T19:57:58Z","receivedAt":"2016-08-11T20:20:21Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/submodule-clone-rr' branch, could\nyou please squash this into the relevant patch (commit 336c21d,\n\"submodule: try alternates when superproject has an alternate\",\n08-08-2016).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/submodule--helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex 4c765e1..4c7d03c 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -641,7 +641,7 @@ struct submodule_alternate_setup {\n \tstruct strbuf *out;\n };\n \n-int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)\n+static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)\n {\n \tstruct submodule_alternate_setup *sas = sas_cb;\n \n-- \n2.9.0\n"},{"id":"298774","messageId":"CAGZ79kZw2E8GDLBvs9MRW90ny8AnszxOcV2yVM8+r2y_sE3=og@mail.gmail.com","threadId":"43713","inReplyTo":"322d7d47-423c-f631-3057-1feb03d50591@ramsayjones.plus.com","subject":"Re: [PATCH] submodule: mark a file-local symbol as static","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-08-11T20:13:06Z","receivedAt":"2016-08-11T20:48:28Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Aug 11, 2016 at 12:57 PM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/submodule-clone-rr' branch, could\n> you please squash this into the relevant patch (commit 336c21d,\n> \"submodule: try alternates when superproject has an alternate\",\n> 08-08-2016).\n\nNot just reroll but rethink and rewrite. ;)\n\nThanks for catching!\nStefan\n\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n>  builtin/submodule--helper.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\n> index 4c765e1..4c7d03c 100644\n> --- a/builtin/submodule--helper.c\n> +++ b/builtin/submodule--helper.c\n> @@ -641,7 +641,7 @@ struct submodule_alternate_setup {\n>         struct strbuf *out;\n>  };\n>\n> -int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)\n> +static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb)\n>  {\n>         struct submodule_alternate_setup *sas = sas_cb;\n>\n> --\n> 2.9.0\n"}]}