# [PATCH] submodule: mark a file-local symbol as static 2 messages from 2016-08-11 to 2016-08-11. Participants: Ramsay Jones, Stefan Beller. Thread: https://gitlist.dev/t/43713 ## Ramsay Jones, 2016-08-11 19:57 Subject: [PATCH] submodule: mark a file-local symbol as static Message-ID: <322d7d47-423c-f631-3057-1feb03d50591@ramsayjones.plus.com> URL: https://gitlist.dev/e/322d7d47-423c-f631-3057-1feb03d50591%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Stefan, If you need to re-roll your 'sb/submodule-clone-rr' branch, could you please squash this into the relevant patch (commit 336c21d, "submodule: try alternates when superproject has an alternate", 08-08-2016). Thanks! ATB, Ramsay Jones builtin/submodule--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 4c765e1..4c7d03c 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -641,7 +641,7 @@ struct submodule_alternate_setup { struct strbuf *out; }; -int add_possible_reference(struct alternate_object_database *alt, void *sas_cb) +static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb) { struct submodule_alternate_setup *sas = sas_cb; -- 2.9.0 ``` ## Stefan Beller, 2016-08-11 20:13 Subject: Re: [PATCH] submodule: mark a file-local symbol as static Message-ID: URL: https://gitlist.dev/e/CAGZ79kZw2E8GDLBvs9MRW90ny8AnszxOcV2yVM8%2Br2y_sE3%3Dog%40mail.gmail.com In-Reply-To: <322d7d47-423c-f631-3057-1feb03d50591@ramsayjones.plus.com> ``` On Thu, Aug 11, 2016 at 12:57 PM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Stefan, > > If you need to re-roll your 'sb/submodule-clone-rr' branch, could > you please squash this into the relevant patch (commit 336c21d, > "submodule: try alternates when superproject has an alternate", > 08-08-2016). Not just reroll but rethink and rewrite. ;) Thanks for catching! Stefan > > Thanks! > > ATB, > Ramsay Jones > > builtin/submodule--helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index 4c765e1..4c7d03c 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -641,7 +641,7 @@ struct submodule_alternate_setup { > struct strbuf *out; > }; > > -int add_possible_reference(struct alternate_object_database *alt, void *sas_cb) > +static int add_possible_reference(struct alternate_object_database *alt, void *sas_cb) > { > struct submodule_alternate_setup *sas = sas_cb; > > -- > 2.9.0 ```