threads / patch / 43709

patchRe: [PATCH] gitweb: esc_html() author in blame

Subject: Re: [PATCH] gitweb: esc_html() author in blame

## tl;dr

3 messages between Oct 30, 2006 and Oct 30, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Luben Tuikov· Oct 30, 2006, 20:37 UTC · lore

[PATCH] gitweb: esc_html() author in blame

Blame fails for example on block/ll_rw_blk.c at v2.6.19-rc3.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitweb/gitweb.perl +1 −1

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c52e19d..177efd3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2751,7 +2751,7 @@ HTML
 		print "<tr class=\"$rev_color[$current_color]\">\n";
 		if ($group_size) {
 			print "<td class=\"sha1\"";
-			print " title=\"$author, $date\"";
+			print " title=\"". esc_html($author) . ", $date\"";
 			print " rowspan=\"$group_size\"" if ($group_size > 1);
 			print ">";
 			print $cgi->a({-href => href(action=>"commit",

-- 
1.4.3.3.g1e64f-dirty

Junio C Hamano· Oct 30, 2006, 22:16 UTC · re: Luben Tuikov · lore

Luben Tuikov <ltuikov@yahoo.com> writes:

> Blame fails for example on
> block/ll_rw_blk.c at v2.6.19-rc3.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

Some quoting may be needed there, but is esc_html the right quoting? Ack, somebody?

Luben Tuikov· Oct 30, 2006, 22:49 UTC · re: Junio C Hamano · lore

--- Junio C Hamano <junkio@cox.net> wrote:

Show 9 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Blame fails for example on
> > block/ll_rw_blk.c at v2.6.19-rc3.
> >
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> Some quoting may be needed there, but is esc_html the right quoting?
> Ack, somebody?

I don't know if it is the right quoting. esc_html() seemed to be used elsewhere for $author, and it seemed to work in this particular case.

    Luben