# Re: [PATCH] gitweb: esc_html() author in blame

3 messages from 2006-10-30 to 2006-10-30. Participants: Junio C Hamano, Luben Tuikov.
Thread: https://gitlist.dev/t/43709

## Luben Tuikov, 2006-10-30 20:37

Subject: [PATCH] gitweb: esc_html() author in blame
Message-ID: <20061030203755.5021.qmail@web31810.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/20061030203755.5021.qmail%40web31810.mail.mud.yahoo.com

```
Blame fails for example on
block/ll_rw_blk.c at v2.6.19-rc3.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c52e19d..177efd3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2751,7 +2751,7 @@ HTML
 		print "<tr class=\"$rev_color[$current_color]\">\n";
 		if ($group_size) {
 			print "<td class=\"sha1\"";
-			print " title=\"$author, $date\"";
+			print " title=\"". esc_html($author) . ", $date\"";
 			print " rowspan=\"$group_size\"" if ($group_size > 1);
 			print ">";
 			print $cgi->a({-href => href(action=>"commit",
-- 
1.4.3.3.g1e64f-dirty

```

## Junio C Hamano, 2006-10-30 22:16

Subject: Re: [PATCH] gitweb: esc_html() author in blame
Message-ID: <7vu01lv48z.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vu01lv48z.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20061030203755.5021.qmail@web31810.mail.mud.yahoo.com>

```
Luben Tuikov <ltuikov@yahoo.com> writes:

> Blame fails for example on
> block/ll_rw_blk.c at v2.6.19-rc3.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

Some quoting may be needed there, but is esc_html the right quoting?
Ack, somebody?

```

## Luben Tuikov, 2006-10-30 22:49

Subject: Re: [PATCH] gitweb: esc_html() author in blame
Message-ID: <429284.77209.qm@web31808.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/429284.77209.qm%40web31808.mail.mud.yahoo.com
In-Reply-To: <7vu01lv48z.fsf@assigned-by-dhcp.cox.net>

```
--- Junio C Hamano <junkio@cox.net> wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Blame fails for example on
> > block/ll_rw_blk.c at v2.6.19-rc3.
> >
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> Some quoting may be needed there, but is esc_html the right quoting?
> Ack, somebody?

I don't know if it is the right quoting.  esc_html() seemed to be
used elsewhere for $author, and it seemed to work in this particular
case.

    Luben

```