{"thread":{"id":"43709","subject":"Re: [PATCH] gitweb: esc_html() author in blame","startedAt":"2006-10-30T20:37:54Z","lastAt":"2006-10-30T22:49:14Z","messageCount":3,"participants":["Junio C Hamano","Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"298051","messageId":"20061030203755.5021.qmail@web31810.mail.mud.yahoo.com","threadId":"43709","inReplyTo":null,"subject":"[PATCH] gitweb: esc_html() author in blame","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-30T20:37:54Z","receivedAt":"2006-10-30T20:37:54Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Blame fails for example on\nblock/ll_rw_blk.c at v2.6.19-rc3.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c52e19d..177efd3 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2751,7 +2751,7 @@ HTML\n \t\tprint \"<tr class=\\\"$rev_color[$current_color]\\\">\\n\";\n \t\tif ($group_size) {\n \t\t\tprint \"<td class=\\\"sha1\\\"\";\n-\t\t\tprint \" title=\\\"$author, $date\\\"\";\n+\t\t\tprint \" title=\\\"\". esc_html($author) . \", $date\\\"\";\n \t\t\tprint \" rowspan=\\\"$group_size\\\"\" if ($group_size > 1);\n \t\t\tprint \">\";\n \t\t\tprint $cgi->a({-href => href(action=>\"commit\",\n-- \n1.4.3.3.g1e64f-dirty\n"},{"id":"297078","messageId":"7vu01lv48z.fsf@assigned-by-dhcp.cox.net","threadId":"43709","inReplyTo":"20061030203755.5021.qmail@web31810.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: esc_html() author in blame","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-30T22:16:28Z","receivedAt":"2006-10-30T22:16:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> Blame fails for example on\n> block/ll_rw_blk.c at v2.6.19-rc3.\n>\n> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>\n\nSome quoting may be needed there, but is esc_html the right quoting?\nAck, somebody?\n"},{"id":"297834","messageId":"429284.77209.qm@web31808.mail.mud.yahoo.com","threadId":"43709","inReplyTo":"7vu01lv48z.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: esc_html() author in blame","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-30T22:49:14Z","receivedAt":"2006-10-30T22:49:14Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> Luben Tuikov <ltuikov@yahoo.com> writes:\n> \n> > Blame fails for example on\n> > block/ll_rw_blk.c at v2.6.19-rc3.\n> >\n> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>\n> \n> Some quoting may be needed there, but is esc_html the right quoting?\n> Ack, somebody?\n\nI don't know if it is the right quoting.  esc_html() seemed to be\nused elsewhere for $author, and it seemed to work in this particular\ncase.\n\n    Luben\n"}]}