threads / rfc / 43512

patchRe: [PATCH/RFC] gitweb: New improved patchset view

Subject: Re: [PATCH/RFC] gitweb: New improved patchset view

## tl;dr

4 messages between Oct 29, 2006 and Oct 29, 2006. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Luben Tuikov· Oct 29, 2006, 19:43 UTC · lore
--- Jakub Narebski <jnareb@gmail.com> wrote:
Show 15 quoted lines
> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> > 
> >> Changes:
> [...]
> >> * <file> hyperlinking should work also when <file> is originally
> >>   quoted. For now we present filename quoted. This needed changes to
> >>   parse_difftree_raw_line subroutine.
> > 
> > This feels Ok.
> 
> Emphasisis on "should". Check
>   http://roke(.)dyndns(.)info/cgi-bin/gitweb/gitweb.cgi?p=git.git;a=commitdiff;h=gitweb/test
> 
> By the way, should we use quoted or unquoted filename?

For dear life, I cannot understand *WTF* is this argument about "quoted" and "unquoted". Can this stop please? PLEASE?

Unquoted, natural, normal.
    Luben
P.S. I don't want to punish the good people who do not put \n or \r or whatnot
in their filenames, just for this one ... "person" who does.  UTF8 is a different
story.
Jakub Narebski· Oct 29, 2006, 20:19 UTC · re: Luben Tuikov · lore
Luben Tuikov wrote:
Show 13 quoted lines
> --- Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> By the way, should we use quoted or unquoted filename?
> 
> For dear life, I cannot understand  *WTF*  is this argument about
> "quoted" and "unquoted".  Can this stop please?  PLEASE?
> 
> Unquoted, natural, normal.
> 
>     Luben
> P.S. I don't want to punish the good people who do not put \n or \r or whatnot
> in their filenames, just for this one ... "person" who does.  UTF8 is a different
> story.

The filenames which don't need quoting are not quoted. Only filenames which need quoting (which have LF ('\n'), TAB ('\t'), \ ('\\') and " (\")) are quoted and surronded in quotes to mark as quoted.

The only thing that is questionable is quoting files which have \ and " and no other strange names.

-- 
Jakub Narebski
Jakub Narebski· Oct 29, 2006, 22:05 UTC · re: Jakub Narebski · lore
Jakub Narebski wrote:
> The filenames which don't need quoting are not quoted. Only filenames
> which need quoting (which have LF ('\n'), TAB ('\t'), \ ('\\') and " (\"))
> are quoted and surronded in quotes to mark as quoted.

By the way, I think that unquote subroutine in gitweb is broken. I think I'll try for new patchser view to work for ordinary filenames (perhaps with metacharacters in them), and only then try to debug for filenames which need quoting.

-- 
Jakub Narebski
Junio C Hamano· Oct 29, 2006, 20:29 UTC · re: Luben Tuikov · lore
Luben Tuikov <ltuikov@yahoo.com> writes:
> For dear life, I cannot understand  *WTF*  is this argument about
> "quoted" and "unquoted".  Can this stop please?  PLEASE?
>
> Unquoted, natural, normal.

I do not think Jakub is talking about quoting normal filenames a/foo that is not quoted by "git diff" into "a/foo" with his code.

I think when "git diff" quotes because of unusual characters gitweb should show it quoted, i.e. as it receives from "git diff".

← back to recent threads