{"thread":{"id":"43512","subject":"Re: [PATCH/RFC] gitweb: New improved patchset view","startedAt":"2006-10-29T19:43:14Z","lastAt":"2006-10-29T22:05:31Z","messageCount":4,"participants":["Jakub Narebski","Junio C Hamano","Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"297824","messageId":"539418.62803.qm@web31807.mail.mud.yahoo.com","threadId":"43512","inReplyTo":"200610291635.09525.jnareb@gmail.com","subject":"Re: [PATCH/RFC] gitweb: New improved patchset view","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-29T19:43:14Z","receivedAt":"2006-10-29T19:43:14Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jakub Narebski <jnareb@gmail.com> wrote:\n> Junio C Hamano wrote:\n> > Jakub Narebski <jnareb@gmail.com> writes:\n> > \n> >> Changes:\n> [...]\n> >> * <file> hyperlinking should work also when <file> is originally\n> >>   quoted. For now we present filename quoted. This needed changes to\n> >>   parse_difftree_raw_line subroutine.\n> > \n> > This feels Ok.\n> \n> Emphasisis on \"should\". Check\n>   http://roke(.)dyndns(.)info/cgi-bin/gitweb/gitweb.cgi?p=git.git;a=commitdiff;h=gitweb/test\n> \n> By the way, should we use quoted or unquoted filename?\n\nFor dear life, I cannot understand  *WTF*  is this argument about\n\"quoted\" and \"unquoted\".  Can this stop please?  PLEASE?\n\nUnquoted, natural, normal.\n\n    Luben\nP.S. I don't want to punish the good people who do not put \\n or \\r or whatnot\nin their filenames, just for this one ... \"person\" who does.  UTF8 is a different\nstory.\n"},{"id":"295225","messageId":"200610292119.05626.jnareb@gmail.com","threadId":"43512","inReplyTo":"539418.62803.qm@web31807.mail.mud.yahoo.com","subject":"Re: [PATCH/RFC] gitweb: New improved patchset view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-29T20:19:05Z","receivedAt":"2006-10-29T20:19:05Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n> --- Jakub Narebski <jnareb@gmail.com> wrote:\n>>\n>> By the way, should we use quoted or unquoted filename?\n> \n> For dear life, I cannot understand  *WTF*  is this argument about\n> \"quoted\" and \"unquoted\".  Can this stop please?  PLEASE?\n> \n> Unquoted, natural, normal.\n> \n>     Luben\n> P.S. I don't want to punish the good people who do not put \\n or \\r or whatnot\n> in their filenames, just for this one ... \"person\" who does.  UTF8 is a different\n> story.\n\nThe filenames which don't need quoting are not quoted. Only filenames\nwhich need quoting (which have LF ('\\n'), TAB ('\\t'), \\ ('\\\\') and \" (\\\"))\nare quoted and surronded in quotes to mark as quoted.\n\nThe only thing that is questionable is quoting files which have \\ and \"\nand no other strange names.\n-- \nJakub Narebski\n"},{"id":"295655","messageId":"7vmz7e27dy.fsf@assigned-by-dhcp.cox.net","threadId":"43512","inReplyTo":"539418.62803.qm@web31807.mail.mud.yahoo.com","subject":"Re: [PATCH/RFC] gitweb: New improved patchset view","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-29T20:29:13Z","receivedAt":"2006-10-29T20:29:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> For dear life, I cannot understand  *WTF*  is this argument about\n> \"quoted\" and \"unquoted\".  Can this stop please?  PLEASE?\n>\n> Unquoted, natural, normal.\n\nI do not think Jakub is talking about quoting normal filenames a/foo\nthat is not quoted by \"git diff\" into \"a/foo\" with his code.\n\nI think when \"git diff\" quotes because of unusual characters\ngitweb should show it quoted, i.e. as it receives from \"git diff\".\n\n"},{"id":"297369","messageId":"200610292305.32088.jnareb@gmail.com","threadId":"43512","inReplyTo":"200610292119.05626.jnareb@gmail.com","subject":"Re: [PATCH/RFC] gitweb: New improved patchset view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-29T22:05:31Z","receivedAt":"2006-10-29T22:05:31Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jakub Narebski wrote:\n\n> The filenames which don't need quoting are not quoted. Only filenames\n> which need quoting (which have LF ('\\n'), TAB ('\\t'), \\ ('\\\\') and \" (\\\"))\n> are quoted and surronded in quotes to mark as quoted.\n\nBy the way, I think that unquote subroutine in gitweb is broken.\nI think I'll try for new patchser view to work for ordinary filenames\n(perhaps with metacharacters in them), and only then try to debug\nfor filenames which need quoting.\n-- \nJakub Narebski\n"}]}