# Re: [PATCH/RFC] gitweb: New improved patchset view

4 messages from 2006-10-29 to 2006-10-29. Participants: Jakub Narebski, Junio C Hamano, Luben Tuikov.
Thread: https://gitlist.dev/t/43512

## Luben Tuikov, 2006-10-29 19:43

Subject: Re: [PATCH/RFC] gitweb: New improved patchset view
Message-ID: <539418.62803.qm@web31807.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/539418.62803.qm%40web31807.mail.mud.yahoo.com
In-Reply-To: <200610291635.09525.jnareb@gmail.com>

```
--- Jakub Narebski <jnareb@gmail.com> wrote:
> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> > 
> >> Changes:
> [...]
> >> * <file> hyperlinking should work also when <file> is originally
> >>   quoted. For now we present filename quoted. This needed changes to
> >>   parse_difftree_raw_line subroutine.
> > 
> > This feels Ok.
> 
> Emphasisis on "should". Check
>   http://roke(.)dyndns(.)info/cgi-bin/gitweb/gitweb.cgi?p=git.git;a=commitdiff;h=gitweb/test
> 
> By the way, should we use quoted or unquoted filename?

For dear life, I cannot understand  *WTF*  is this argument about
"quoted" and "unquoted".  Can this stop please?  PLEASE?

Unquoted, natural, normal.

    Luben
P.S. I don't want to punish the good people who do not put \n or \r or whatnot
in their filenames, just for this one ... "person" who does.  UTF8 is a different
story.

```

## Jakub Narebski, 2006-10-29 20:19

Subject: Re: [PATCH/RFC] gitweb: New improved patchset view
Message-ID: <200610292119.05626.jnareb@gmail.com>
URL: https://gitlist.dev/e/200610292119.05626.jnareb%40gmail.com
In-Reply-To: <539418.62803.qm@web31807.mail.mud.yahoo.com>

```
Luben Tuikov wrote:
> --- Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> By the way, should we use quoted or unquoted filename?
> 
> For dear life, I cannot understand  *WTF*  is this argument about
> "quoted" and "unquoted".  Can this stop please?  PLEASE?
> 
> Unquoted, natural, normal.
> 
>     Luben
> P.S. I don't want to punish the good people who do not put \n or \r or whatnot
> in their filenames, just for this one ... "person" who does.  UTF8 is a different
> story.

The filenames which don't need quoting are not quoted. Only filenames
which need quoting (which have LF ('\n'), TAB ('\t'), \ ('\\') and " (\"))
are quoted and surronded in quotes to mark as quoted.

The only thing that is questionable is quoting files which have \ and "
and no other strange names.
-- 
Jakub Narebski

```

## Junio C Hamano, 2006-10-29 20:29

Subject: Re: [PATCH/RFC] gitweb: New improved patchset view
Message-ID: <7vmz7e27dy.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vmz7e27dy.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <539418.62803.qm@web31807.mail.mud.yahoo.com>

```
Luben Tuikov <ltuikov@yahoo.com> writes:

> For dear life, I cannot understand  *WTF*  is this argument about
> "quoted" and "unquoted".  Can this stop please?  PLEASE?
>
> Unquoted, natural, normal.

I do not think Jakub is talking about quoting normal filenames a/foo
that is not quoted by "git diff" into "a/foo" with his code.

I think when "git diff" quotes because of unusual characters
gitweb should show it quoted, i.e. as it receives from "git diff".


```

## Jakub Narebski, 2006-10-29 22:05

Subject: Re: [PATCH/RFC] gitweb: New improved patchset view
Message-ID: <200610292305.32088.jnareb@gmail.com>
URL: https://gitlist.dev/e/200610292305.32088.jnareb%40gmail.com
In-Reply-To: <200610292119.05626.jnareb@gmail.com>

```
Jakub Narebski wrote:

> The filenames which don't need quoting are not quoted. Only filenames
> which need quoting (which have LF ('\n'), TAB ('\t'), \ ('\\') and " (\"))
> are quoted and surronded in quotes to mark as quoted.

By the way, I think that unquote subroutine in gitweb is broken.
I think I'll try for new patchser view to work for ordinary filenames
(perhaps with metacharacters in them), and only then try to debug
for filenames which need quoting.
-- 
Jakub Narebski

```