threads / discuss / 43290

Re: gitweb.cgi and git instaweb

Subject: Re: gitweb.cgi and git instaweb

## tl;dr

5 messages between Oct 26, 2006 and Oct 27, 2006.

replies: 4people: 3as markdown or json

Aneesh Kumar K.V· Oct 26, 2006, 18:49 UTC · lore

gitweb.cgi and git instaweb

I am getting errors as below with git instaweb.

kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb 2006-10-27 00:12:56: (log.c.75) server started kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:21 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:37 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:58 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:14:08 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:14:08 2006] gitweb.cgi: Use of uninitialized value in open at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 1118. fatal: ambiguous argument '': unknown revision or path not in the working tree. Use '--' to separate paths from revisions [Fri Oct 27 00:14:16 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.

Aneesh Kumar K.V· Oct 27, 2006, 05:56 UTC · re: Aneesh Kumar K.V · lore

Aneesh Kumar K.V wrote:

Show 9 quoted lines

> I am getting errors as below with git instaweb.
> 
> 
> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
> 2006-10-27 00:12:56: (log.c.75) server started
> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 
> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier 
> declaration in same scope at 
>

The attached patch should fix it.

-aneesh

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ba7a42a..1962c76 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -55,8 +55,6 @@ our $stylesheet;
 # default is not to define style sheet, but it can be overwritten later
 undef $stylesheet;
 
-# URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

Junio C Hamano· Oct 27, 2006, 07:05 UTC · re: Aneesh Kumar K.V · lore

"Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:

Show 27 quoted lines

> Aneesh Kumar K.V wrote:
>> I am getting errors as below with git instaweb.
>>
>>
>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
>> 2006-10-27 00:12:56: (log.c.75) server started
>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
>> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
>> declaration in same scope at
>>
>
> The attached patch should fix it.
>
> -aneesh
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ba7a42a..1962c76 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -55,8 +55,6 @@ our $stylesheet;
>  # default is not to define style sheet, but it can be overwritten later
>  undef $stylesheet;
>  
> -# URI of default stylesheet
> -our $stylesheet = "++GITWEB_CSS++";
>  # URI of GIT logo (72x27 size)
>  our $logo = "++GITWEB_LOGO++";
>  # URI of GIT favicon, assumed to be image/png type

Removing the extraneous undef would also be a good idea, wouldn't it?

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index aceaeb7..7999b1a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
 
 # URI of stylesheets
 our @stylesheets = ("++GITWEB_CSS++");
-our $stylesheet;
-# default is not to define style sheet, but it can be overwritten later
-undef $stylesheet;
-
 # URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
+# default is not to define style sheet, but it can be overwritten later.
+our $stylesheet = undef;
+
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

Aneesh Kumar K.V· Oct 27, 2006, 08:58 UTC · re: Junio C Hamano · lore

Junio C Hamano wrote:

Show 53 quoted lines

> "Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
> 
>> Aneesh Kumar K.V wrote:
>>> I am getting errors as below with git instaweb.
>>>
>>>
>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
>>> 2006-10-27 00:12:56: (log.c.75) server started
>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
>>> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
>>> declaration in same scope at
>>>
>> The attached patch should fix it.
>>
>> -aneesh
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index ba7a42a..1962c76 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -55,8 +55,6 @@ our $stylesheet;
>>  # default is not to define style sheet, but it can be overwritten later
>>  undef $stylesheet;
>>  
>> -# URI of default stylesheet
>> -our $stylesheet = "++GITWEB_CSS++";
>>  # URI of GIT logo (72x27 size)
>>  our $logo = "++GITWEB_LOGO++";
>>  # URI of GIT favicon, assumed to be image/png type
> 
> Removing the extraneous undef would also be a good idea,
> wouldn't it?
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index aceaeb7..7999b1a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
>  
>  # URI of stylesheets
>  our @stylesheets = ("++GITWEB_CSS++");
> -our $stylesheet;
> -# default is not to define style sheet, but it can be overwritten later
> -undef $stylesheet;
> -
>  # URI of default stylesheet
> -our $stylesheet = "++GITWEB_CSS++";
> +# default is not to define style sheet, but it can be overwritten later.
> +our $stylesheet = undef;
> +
>  # URI of GIT logo (72x27 size)
>  our $logo = "++GITWEB_LOGO++";
>  # URI of GIT favicon, assumed to be image/png type
>

ACK

Petr Baudis· Oct 27, 2006, 10:32 UTC · re: Junio C Hamano · lore

Dear diary, on Fri, Oct 27, 2006 at 09:05:20AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

> Removing the extraneous undef would also be a good idea,
> wouldn't it?

25746   F Oct 26 Petr Baudis     ( 0.9K) [PATCH] gitweb: Fix up bogus $stylesheet declarations

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1