# Re: gitweb.cgi and git instaweb 5 messages from 2006-10-26 to 2006-10-27. Participants: Petr Baudis, Aneesh Kumar K.V, Junio C Hamano. Thread: https://gitlist.dev/t/43290 ## Aneesh Kumar K.V, 2006-10-26 18:49 Subject: gitweb.cgi and git instaweb Message-ID: URL: https://gitlist.dev/e/ehr00n%24vbe%241%40sea.gmane.org ``` I am getting errors as below with git instaweb. kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb 2006-10-27 00:12:56: (log.c.75) server started kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:21 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:37 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:13:58 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:14:08 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. [Fri Oct 27 00:14:08 2006] gitweb.cgi: Use of uninitialized value in open at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 1118. fatal: ambiguous argument '': unknown revision or path not in the working tree. Use '--' to separate paths from revisions [Fri Oct 27 00:14:16 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59. ``` ## Aneesh Kumar K.V, 2006-10-27 05:56 Subject: Re: gitweb.cgi and git instaweb Message-ID: <45419F75.6060103@gmail.com> URL: https://gitlist.dev/e/45419F75.6060103%40gmail.com In-Reply-To: ``` Aneesh Kumar K.V wrote: > I am getting errors as below with git instaweb. > > > kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb > 2006-10-27 00:12:56: (log.c.75) server started > kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 > 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier > declaration in same scope at > The attached patch should fix it. -aneesh diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index ba7a42a..1962c76 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -55,8 +55,6 @@ our $stylesheet; # default is not to define style sheet, but it can be overwritten later undef $stylesheet; -# URI of default stylesheet -our $stylesheet = "++GITWEB_CSS++"; # URI of GIT logo (72x27 size) our $logo = "++GITWEB_LOGO++"; # URI of GIT favicon, assumed to be image/png type ``` ## Junio C Hamano, 2006-10-27 07:05 Subject: Re: gitweb.cgi and git instaweb Message-ID: <7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v8xj2i6hb.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <45419F75.6060103@gmail.com> ``` "Aneesh Kumar K.V" writes: > Aneesh Kumar K.V wrote: >> I am getting errors as below with git instaweb. >> >> >> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb >> 2006-10-27 00:12:56: (log.c.75) server started >> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 >> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier >> declaration in same scope at >> > > The attached patch should fix it. > > -aneesh > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index ba7a42a..1962c76 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -55,8 +55,6 @@ our $stylesheet; > # default is not to define style sheet, but it can be overwritten later > undef $stylesheet; > > -# URI of default stylesheet > -our $stylesheet = "++GITWEB_CSS++"; > # URI of GIT logo (72x27 size) > our $logo = "++GITWEB_LOGO++"; > # URI of GIT favicon, assumed to be image/png type Removing the extraneous undef would also be a good idea, wouldn't it? diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index aceaeb7..7999b1a 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER # URI of stylesheets our @stylesheets = ("++GITWEB_CSS++"); -our $stylesheet; -# default is not to define style sheet, but it can be overwritten later -undef $stylesheet; - # URI of default stylesheet -our $stylesheet = "++GITWEB_CSS++"; +# default is not to define style sheet, but it can be overwritten later. +our $stylesheet = undef; + # URI of GIT logo (72x27 size) our $logo = "++GITWEB_LOGO++"; # URI of GIT favicon, assumed to be image/png type ``` ## Aneesh Kumar K.V, 2006-10-27 08:58 Subject: Re: gitweb.cgi and git instaweb Message-ID: <4541CA50.6060901@gmail.com> URL: https://gitlist.dev/e/4541CA50.6060901%40gmail.com In-Reply-To: <7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > "Aneesh Kumar K.V" writes: > >> Aneesh Kumar K.V wrote: >>> I am getting errors as below with git instaweb. >>> >>> >>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb >>> 2006-10-27 00:12:56: (log.c.75) server started >>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 >>> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier >>> declaration in same scope at >>> >> The attached patch should fix it. >> >> -aneesh >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl >> index ba7a42a..1962c76 100755 >> --- a/gitweb/gitweb.perl >> +++ b/gitweb/gitweb.perl >> @@ -55,8 +55,6 @@ our $stylesheet; >> # default is not to define style sheet, but it can be overwritten later >> undef $stylesheet; >> >> -# URI of default stylesheet >> -our $stylesheet = "++GITWEB_CSS++"; >> # URI of GIT logo (72x27 size) >> our $logo = "++GITWEB_LOGO++"; >> # URI of GIT favicon, assumed to be image/png type > > Removing the extraneous undef would also be a good idea, > wouldn't it? > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index aceaeb7..7999b1a 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER > > # URI of stylesheets > our @stylesheets = ("++GITWEB_CSS++"); > -our $stylesheet; > -# default is not to define style sheet, but it can be overwritten later > -undef $stylesheet; > - > # URI of default stylesheet > -our $stylesheet = "++GITWEB_CSS++"; > +# default is not to define style sheet, but it can be overwritten later. > +our $stylesheet = undef; > + > # URI of GIT logo (72x27 size) > our $logo = "++GITWEB_LOGO++"; > # URI of GIT favicon, assumed to be image/png type > ACK ``` ## Petr Baudis, 2006-10-27 10:32 Subject: Re: gitweb.cgi and git instaweb Message-ID: <20061027103211.GA20017@pasky.or.cz> URL: https://gitlist.dev/e/20061027103211.GA20017%40pasky.or.cz In-Reply-To: <7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net> ``` Dear diary, on Fri, Oct 27, 2006 at 09:05:20AM CEST, I got a letter where Junio C Hamano said that... > Removing the extraneous undef would also be a good idea, > wouldn't it? 25746 F Oct 26 Petr Baudis ( 0.9K) [PATCH] gitweb: Fix up bogus $stylesheet declarations ? -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i