{"thread":{"id":"43290","subject":"Re: gitweb.cgi and git instaweb","startedAt":"2006-10-26T18:49:59Z","lastAt":"2006-10-27T10:32:11Z","messageCount":5,"participants":["Petr Baudis","Aneesh Kumar K.V","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"298431","messageId":"ehr00n$vbe$1@sea.gmane.org","threadId":"43290","inReplyTo":null,"subject":"gitweb.cgi and git instaweb","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-10-26T18:49:59Z","receivedAt":"2006-10-26T18:49:59Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"I am getting errors as below with git instaweb.\n\n\nkvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb\n2006-10-27 00:12:56: (log.c.75) server started\nkvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 00:12:57 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n[Fri Oct 27 00:13:21 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n[Fri Oct 27 00:13:37 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n[Fri Oct 27 00:13:58 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n[Fri Oct 27 00:14:08 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n[Fri Oct 27 00:14:08 2006] gitweb.cgi: Use of uninitialized value in open at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 1118.\nfatal: ambiguous argument '': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions\n[Fri Oct 27 00:14:16 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.\n"},{"id":"295446","messageId":"45419F75.6060103@gmail.com","threadId":"43290","inReplyTo":"ehr00n$vbe$1@sea.gmane.org","subject":"Re: gitweb.cgi and git instaweb","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-10-27T05:56:05Z","receivedAt":"2006-10-27T05:56:05Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"Aneesh Kumar K.V wrote:\n> I am getting errors as below with git instaweb.\n> \n> \n> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb\n> 2006-10-27 00:12:56: (log.c.75) server started\n> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 \n> 00:12:57 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier \n> declaration in same scope at \n>\n\nThe attached patch should fix it.\n\n-aneesh\n\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ba7a42a..1962c76 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -55,8 +55,6 @@ our $stylesheet;\n # default is not to define style sheet, but it can be overwritten later\n undef $stylesheet;\n \n-# URI of default stylesheet\n-our $stylesheet = \"++GITWEB_CSS++\";\n # URI of GIT logo (72x27 size)\n our $logo = \"++GITWEB_LOGO++\";\n # URI of GIT favicon, assumed to be image/png type\n"},{"id":"297850","messageId":"7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net","threadId":"43290","inReplyTo":"45419F75.6060103@gmail.com","subject":"Re: gitweb.cgi and git instaweb","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-27T07:05:20Z","receivedAt":"2006-10-27T07:05:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Aneesh Kumar K.V\" <aneesh.kumar@gmail.com> writes:\n\n> Aneesh Kumar K.V wrote:\n>> I am getting errors as below with git instaweb.\n>>\n>>\n>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb\n>> 2006-10-27 00:12:56: (log.c.75) server started\n>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27\n>> 00:12:57 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier\n>> declaration in same scope at\n>>\n>\n> The attached patch should fix it.\n>\n> -aneesh\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index ba7a42a..1962c76 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -55,8 +55,6 @@ our $stylesheet;\n>  # default is not to define style sheet, but it can be overwritten later\n>  undef $stylesheet;\n>  \n> -# URI of default stylesheet\n> -our $stylesheet = \"++GITWEB_CSS++\";\n>  # URI of GIT logo (72x27 size)\n>  our $logo = \"++GITWEB_LOGO++\";\n>  # URI of GIT favicon, assumed to be image/png type\n\nRemoving the extraneous undef would also be a good idea,\nwouldn't it?\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex aceaeb7..7999b1a 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -51,12 +51,10 @@ our $site_footer = \"++GITWEB_SITE_FOOTER\n \n # URI of stylesheets\n our @stylesheets = (\"++GITWEB_CSS++\");\n-our $stylesheet;\n-# default is not to define style sheet, but it can be overwritten later\n-undef $stylesheet;\n-\n # URI of default stylesheet\n-our $stylesheet = \"++GITWEB_CSS++\";\n+# default is not to define style sheet, but it can be overwritten later.\n+our $stylesheet = undef;\n+\n # URI of GIT logo (72x27 size)\n our $logo = \"++GITWEB_LOGO++\";\n # URI of GIT favicon, assumed to be image/png type\n"},{"id":"297064","messageId":"4541CA50.6060901@gmail.com","threadId":"43290","inReplyTo":"7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net","subject":"Re: gitweb.cgi and git instaweb","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-10-27T08:58:56Z","receivedAt":"2006-10-27T08:58:56Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> \"Aneesh Kumar K.V\" <aneesh.kumar@gmail.com> writes:\n> \n>> Aneesh Kumar K.V wrote:\n>>> I am getting errors as below with git instaweb.\n>>>\n>>>\n>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb\n>>> 2006-10-27 00:12:56: (log.c.75) server started\n>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27\n>>> 00:12:57 2006] gitweb.cgi: \"our\" variable $stylesheet masks earlier\n>>> declaration in same scope at\n>>>\n>> The attached patch should fix it.\n>>\n>> -aneesh\n>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n>> index ba7a42a..1962c76 100755\n>> --- a/gitweb/gitweb.perl\n>> +++ b/gitweb/gitweb.perl\n>> @@ -55,8 +55,6 @@ our $stylesheet;\n>>  # default is not to define style sheet, but it can be overwritten later\n>>  undef $stylesheet;\n>>  \n>> -# URI of default stylesheet\n>> -our $stylesheet = \"++GITWEB_CSS++\";\n>>  # URI of GIT logo (72x27 size)\n>>  our $logo = \"++GITWEB_LOGO++\";\n>>  # URI of GIT favicon, assumed to be image/png type\n> \n> Removing the extraneous undef would also be a good idea,\n> wouldn't it?\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index aceaeb7..7999b1a 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -51,12 +51,10 @@ our $site_footer = \"++GITWEB_SITE_FOOTER\n>  \n>  # URI of stylesheets\n>  our @stylesheets = (\"++GITWEB_CSS++\");\n> -our $stylesheet;\n> -# default is not to define style sheet, but it can be overwritten later\n> -undef $stylesheet;\n> -\n>  # URI of default stylesheet\n> -our $stylesheet = \"++GITWEB_CSS++\";\n> +# default is not to define style sheet, but it can be overwritten later.\n> +our $stylesheet = undef;\n> +\n>  # URI of GIT logo (72x27 size)\n>  our $logo = \"++GITWEB_LOGO++\";\n>  # URI of GIT favicon, assumed to be image/png type\n> \n\nACK\n\n"},{"id":"294241","messageId":"20061027103211.GA20017@pasky.or.cz","threadId":"43290","inReplyTo":"7v8xj2i6hb.fsf@assigned-by-dhcp.cox.net","subject":"Re: gitweb.cgi and git instaweb","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-27T10:32:11Z","receivedAt":"2006-10-27T10:32:11Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Oct 27, 2006 at 09:05:20AM CEST, I got a letter\nwhere Junio C Hamano <junkio@cox.net> said that...\n> Removing the extraneous undef would also be a good idea,\n> wouldn't it?\n\n25746   F Oct 26 Petr Baudis     ( 0.9K) [PATCH] gitweb: Fix up bogus $stylesheet declarations\n\n?\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\n"}]}