threads / discuss / 4319

git-format-patch question

Subject: git-format-patch question

## tl;dr

3 messages between May 28, 2006 and May 29, 2006.

replies: 2people: 2as markdown or json

Seth Falcon· May 28, 2006, 19:31 UTC · lore

Hi,

A few questions about git-format-patch:

1. When is one supposed to use --signoff?  I gather the answer is
   project specific, but a statement of what's expected for git
   itself would probably help clarify things for me.

2. How should I add extra notes to an email generated using
   git-format-patch?  Is this in the docs somewhere that I missed?  Is
   there a recommended way to do this?

3. Is signoff broken? I get:

    $ git-format-patch --stdout --signoff master
    fatal: unrecognized argument: --signoff

   When I pass -s instead of --signoff, I get output, but no patch and
   no signoff looking thing.  Without --signoff and without -s, I get
   reasonable looking output.

Thanks,

+ seth

Junio C Hamano· May 28, 2006, 20:35 UTC · re: Seth Falcon · lore

Re: git-format-patch question

Seth Falcon <sethfalcon@gmail.com> writes:

> 1. When is one supposed to use --signoff?  I gather the answer is
>    project specific, but a statement of what's expected for git
>    itself would probably help clarify things for me.

You shouldn't ;-). Rather, you should sign-off when you make a commit, or if you are forwarding somebody else's patch, before you send the e-mail off.

> 2. How should I add extra notes to an email generated using
>    git-format-patch?  Is this in the docs somewhere that I missed?  Is
>    there a recommended way to do this?

Read the format-patch output in your e-mail buffer and edit just like you edit any text you write in your e-mail.

Seth Falcon· May 29, 2006, 01:01 UTC · re: Junio C Hamano · lore

Re: git-format-patch question

Junio C Hamano <junkio@cox.net> writes:

Show 16 quoted lines

> Seth Falcon <sethfalcon@gmail.com> writes:
>
>> 1. When is one supposed to use --signoff?  I gather the answer is
>>    project specific, but a statement of what's expected for git
>>    itself would probably help clarify things for me.
>
> You shouldn't ;-).  Rather, you should sign-off when you make a
> commit, or if you are forwarding somebody else's patch, before
> you send the e-mail off.  
>
>> 2. How should I add extra notes to an email generated using
>>    git-format-patch?  Is this in the docs somewhere that I missed?  Is
>>    there a recommended way to do this?
>
> Read the format-patch output in your e-mail buffer and edit just
> like you edit any text you write in your e-mail.

Thanks for the quick answers. I guess I was imagining things to be more complicated than they are :-)