{"thread":{"id":"4319","subject":"git-format-patch question","startedAt":"2006-05-28T19:31:33Z","lastAt":"2006-05-29T01:01:07Z","messageCount":3,"participants":["Seth Falcon","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"20832","messageId":"m2odxikktm.fsf@ziti.fhcrc.org","threadId":"4319","inReplyTo":null,"subject":"git-format-patch question","fromName":"Seth Falcon","fromEmail":"sethfalcon@gmail.com","sentAt":"2006-05-28T19:31:33Z","receivedAt":"2006-05-28T19:31:33Z","isPatch":false,"sender":{"key":"sethfalcon@gmail.com","avatar":"https://gravatar.com/avatar/fd62fe73d3013b12fce71d5269ec52eaca3c4cee479efc6eea3603d6f1d8bf8d?d=mp&s=160"},"body":"Hi,\n\nA few questions about git-format-patch:\n\n1. When is one supposed to use --signoff?  I gather the answer is\n   project specific, but a statement of what's expected for git\n   itself would probably help clarify things for me.\n\n2. How should I add extra notes to an email generated using\n   git-format-patch?  Is this in the docs somewhere that I missed?  Is\n   there a recommended way to do this?\n\n3. Is signoff broken? I get:\n\n    $ git-format-patch --stdout --signoff master\n    fatal: unrecognized argument: --signoff  \n\n   When I pass -s instead of --signoff, I get output, but no patch and\n   no signoff looking thing.  Without --signoff and without -s, I get\n   reasonable looking output.\n\nThanks,\n\n+ seth\n"},{"id":"20833","messageId":"7vpshxdh0s.fsf@assigned-by-dhcp.cox.net","threadId":"4319","inReplyTo":"m2odxikktm.fsf@ziti.fhcrc.org","subject":"Re: git-format-patch question","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-28T20:35:31Z","receivedAt":"2006-05-28T20:35:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Seth Falcon <sethfalcon@gmail.com> writes:\n\n> 1. When is one supposed to use --signoff?  I gather the answer is\n>    project specific, but a statement of what's expected for git\n>    itself would probably help clarify things for me.\n\nYou shouldn't ;-).  Rather, you should sign-off when you make a\ncommit, or if you are forwarding somebody else's patch, before\nyou send the e-mail off.  \n\n> 2. How should I add extra notes to an email generated using\n>    git-format-patch?  Is this in the docs somewhere that I missed?  Is\n>    there a recommended way to do this?\n\nRead the format-patch output in your e-mail buffer and edit just\nlike you edit any text you write in your e-mail.\n"},{"id":"20855","messageId":"m2irnplk4s.fsf@ziti.fhcrc.org","threadId":"4319","inReplyTo":"7vpshxdh0s.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-format-patch question","fromName":"Seth Falcon","fromEmail":"sethfalcon@gmail.com","sentAt":"2006-05-29T01:01:07Z","receivedAt":"2006-05-29T01:01:07Z","isPatch":false,"sender":{"key":"sethfalcon@gmail.com","avatar":"https://gravatar.com/avatar/fd62fe73d3013b12fce71d5269ec52eaca3c4cee479efc6eea3603d6f1d8bf8d?d=mp&s=160"},"body":"Junio C Hamano <junkio@cox.net> writes:\n\n> Seth Falcon <sethfalcon@gmail.com> writes:\n>\n>> 1. When is one supposed to use --signoff?  I gather the answer is\n>>    project specific, but a statement of what's expected for git\n>>    itself would probably help clarify things for me.\n>\n> You shouldn't ;-).  Rather, you should sign-off when you make a\n> commit, or if you are forwarding somebody else's patch, before\n> you send the e-mail off.  \n>\n>> 2. How should I add extra notes to an email generated using\n>>    git-format-patch?  Is this in the docs somewhere that I missed?  Is\n>>    there a recommended way to do this?\n>\n> Read the format-patch output in your e-mail buffer and edit just\n> like you edit any text you write in your e-mail.\n\nThanks for the quick answers.  I guess I was imagining things to be\nmore complicated than they are :-)\n"}]}