# git-format-patch question 3 messages from 2006-05-28 to 2006-05-29. Participants: Seth Falcon, Junio C Hamano. Thread: https://gitlist.dev/t/4319 ## Seth Falcon, 2006-05-28 19:31 Subject: git-format-patch question Message-ID: URL: https://gitlist.dev/e/m2odxikktm.fsf%40ziti.fhcrc.org ``` Hi, A few questions about git-format-patch: 1. When is one supposed to use --signoff? I gather the answer is project specific, but a statement of what's expected for git itself would probably help clarify things for me. 2. How should I add extra notes to an email generated using git-format-patch? Is this in the docs somewhere that I missed? Is there a recommended way to do this? 3. Is signoff broken? I get: $ git-format-patch --stdout --signoff master fatal: unrecognized argument: --signoff When I pass -s instead of --signoff, I get output, but no patch and no signoff looking thing. Without --signoff and without -s, I get reasonable looking output. Thanks, + seth ``` ## Junio C Hamano, 2006-05-28 20:35 Subject: Re: git-format-patch question Message-ID: <7vpshxdh0s.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vpshxdh0s.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Seth Falcon writes: > 1. When is one supposed to use --signoff? I gather the answer is > project specific, but a statement of what's expected for git > itself would probably help clarify things for me. You shouldn't ;-). Rather, you should sign-off when you make a commit, or if you are forwarding somebody else's patch, before you send the e-mail off. > 2. How should I add extra notes to an email generated using > git-format-patch? Is this in the docs somewhere that I missed? Is > there a recommended way to do this? Read the format-patch output in your e-mail buffer and edit just like you edit any text you write in your e-mail. ``` ## Seth Falcon, 2006-05-29 01:01 Subject: Re: git-format-patch question Message-ID: URL: https://gitlist.dev/e/m2irnplk4s.fsf%40ziti.fhcrc.org In-Reply-To: <7vpshxdh0s.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano writes: > Seth Falcon writes: > >> 1. When is one supposed to use --signoff? I gather the answer is >> project specific, but a statement of what's expected for git >> itself would probably help clarify things for me. > > You shouldn't ;-). Rather, you should sign-off when you make a > commit, or if you are forwarding somebody else's patch, before > you send the e-mail off. > >> 2. How should I add extra notes to an email generated using >> git-format-patch? Is this in the docs somewhere that I missed? Is >> there a recommended way to do this? > > Read the format-patch output in your e-mail buffer and edit just > like you edit any text you write in your e-mail. Thanks for the quick answers. I guess I was imagining things to be more complicated than they are :-) ```