threads / patch / 42451

patchclone: don't use an integer as a NULL pointer

Subject: [PATCH] clone: don't use an integer as a NULL pointer

## tl;dr

3 messages between May 25, 2016 and May 26, 2016. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· May 25, 2016, 23:12 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Stefan,

If you need to re-roll your 'sb/submodule-default-paths' branch, could you please squash this into the relevant patch. (commit 8efbe28b, "clone: add --init-submodule=<pathspec> switch", 23-05-2016).

Thanks!

ATB, Ramsay Jones

 builtin/clone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/clone.c +1 −1
diff --git a/builtin/clone.c b/builtin/clone.c
index 22b6eac..a056f72 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 		struct strbuf sb = STRBUF_INIT;
 		for_each_string_list_item(item, &init_submodules) {
 			strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
-			string_list_append(&option_config, strbuf_detach(&sb, 0));
+			string_list_append(&option_config, strbuf_detach(&sb, NULL));
 		}
 	}
 
-- 
2.8.0
Stefan Beller· May 25, 2016, 23:30 UTC · re: Ramsay Jones · lore

Re: [PATCH] clone: don't use an integer as a NULL pointer

On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 14 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-default-paths' branch, could
> you please squash this into the relevant patch. (commit 8efbe28b,
> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>
> Thanks!
>
> ATB,
> Ramsay Jones
Thanks for pointing out!

I am sorry for having you write me these emails; Out of curiosity, how much of this is manual work and how much did you automate of this?

Show 19 quoted lines
>
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 22b6eac..a056f72 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>                 struct strbuf sb = STRBUF_INIT;
>                 for_each_string_list_item(item, &init_submodules) {
>                         strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
> -                       string_list_append(&option_config, strbuf_detach(&sb, 0));
> +                       string_list_append(&option_config, strbuf_detach(&sb, NULL));
>                 }
>         }
>
> --
> 2.8.0
Ramsay Jones· May 26, 2016, 00:32 UTC · re: Stefan Beller · lore

Re: [PATCH] clone: don't use an integer as a NULL pointer

On 26/05/16 00:30, Stefan Beller wrote:
Show 20 quoted lines
> On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Stefan,
>>
>> If you need to re-roll your 'sb/submodule-default-paths' branch, could
>> you please squash this into the relevant patch. (commit 8efbe28b,
>> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
> 
> Thanks for pointing out!
> 
> I am sorry for having you write me these emails;
It's no problem ...
> Out of curiosity, how much of this is manual work and how
> much did you automate of this?
... because this particular problem is caught by 'make sparse'.

[OK, I have to write the patch, test, etc. manually, but that's not a great burden.]

ATB, Ramsay Jones

← back to recent threads