# [PATCH] clone: don't use an integer as a NULL pointer

3 messages from 2016-05-25 to 2016-05-26. Participants: Ramsay Jones, Stefan Beller.
Thread: https://gitlist.dev/t/42451

## Ramsay Jones, 2016-05-25 23:12

Subject: [PATCH] clone: don't use an integer as a NULL pointer
Message-ID: <5746316E.8020902@ramsayjones.plus.com>
URL: https://gitlist.dev/e/5746316E.8020902%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Stefan,

If you need to re-roll your 'sb/submodule-default-paths' branch, could
you please squash this into the relevant patch. (commit 8efbe28b,
"clone: add --init-submodule=<pathspec> switch", 23-05-2016).

Thanks!

ATB,
Ramsay Jones

 builtin/clone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/clone.c b/builtin/clone.c
index 22b6eac..a056f72 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 		struct strbuf sb = STRBUF_INIT;
 		for_each_string_list_item(item, &init_submodules) {
 			strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
-			string_list_append(&option_config, strbuf_detach(&sb, 0));
+			string_list_append(&option_config, strbuf_detach(&sb, NULL));
 		}
 	}
 
-- 
2.8.0

```

## Stefan Beller, 2016-05-25 23:30

Subject: Re: [PATCH] clone: don't use an integer as a NULL pointer
Message-ID: <CAGZ79kaEtayuY8ZdB5hD_uYK8qZKQ1kiP3tPchjUm4k_HuVyow@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kaEtayuY8ZdB5hD_uYK8qZKQ1kiP3tPchjUm4k_HuVyow%40mail.gmail.com
In-Reply-To: <5746316E.8020902@ramsayjones.plus.com>

```
On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-default-paths' branch, could
> you please squash this into the relevant patch. (commit 8efbe28b,
> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>
> Thanks!
>
> ATB,
> Ramsay Jones

Thanks for pointing out!

I am sorry for having you write me these emails;
Out of curiosity, how much of this is manual work and how
much did you automate of this?

>
>  builtin/clone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 22b6eac..a056f72 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>                 struct strbuf sb = STRBUF_INIT;
>                 for_each_string_list_item(item, &init_submodules) {
>                         strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
> -                       string_list_append(&option_config, strbuf_detach(&sb, 0));
> +                       string_list_append(&option_config, strbuf_detach(&sb, NULL));
>                 }
>         }
>
> --
> 2.8.0

```

## Ramsay Jones, 2016-05-26 00:32

Subject: Re: [PATCH] clone: don't use an integer as a NULL pointer
Message-ID: <5746443B.6060006@ramsayjones.plus.com>
URL: https://gitlist.dev/e/5746443B.6060006%40ramsayjones.plus.com
In-Reply-To: <CAGZ79kaEtayuY8ZdB5hD_uYK8qZKQ1kiP3tPchjUm4k_HuVyow@mail.gmail.com>

```


On 26/05/16 00:30, Stefan Beller wrote:
> On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Stefan,
>>
>> If you need to re-roll your 'sb/submodule-default-paths' branch, could
>> you please squash this into the relevant patch. (commit 8efbe28b,
>> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
> 
> Thanks for pointing out!
> 
> I am sorry for having you write me these emails;

It's no problem ...

> Out of curiosity, how much of this is manual work and how
> much did you automate of this?

... because this particular problem is caught by 'make sparse'.

[OK, I have to write the patch, test, etc. manually, but that's
not a great burden.]

ATB,
Ramsay Jones

```