{"thread":{"id":"42451","subject":"[PATCH] clone: don't use an integer as a NULL pointer","startedAt":"2016-05-25T23:12:46Z","lastAt":"2016-05-26T00:32:59Z","messageCount":3,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"287536","messageId":"5746316E.8020902@ramsayjones.plus.com","threadId":"42451","inReplyTo":null,"subject":"[PATCH] clone: don't use an integer as a NULL pointer","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-05-25T23:12:46Z","receivedAt":"2016-05-25T23:12:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/submodule-default-paths' branch, could\nyou please squash this into the relevant patch. (commit 8efbe28b,\n\"clone: add --init-submodule=<pathspec> switch\", 23-05-2016).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/clone.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 22b6eac..a056f72 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\tstruct strbuf sb = STRBUF_INIT;\n \t\tfor_each_string_list_item(item, &init_submodules) {\n \t\t\tstrbuf_addf(&sb, \"submodule.defaultUpdatePath=%s\", item->string);\n-\t\t\tstring_list_append(&option_config, strbuf_detach(&sb, 0));\n+\t\t\tstring_list_append(&option_config, strbuf_detach(&sb, NULL));\n \t\t}\n \t}\n \n-- \n2.8.0\n"},{"id":"287539","messageId":"CAGZ79kaEtayuY8ZdB5hD_uYK8qZKQ1kiP3tPchjUm4k_HuVyow@mail.gmail.com","threadId":"42451","inReplyTo":"5746316E.8020902@ramsayjones.plus.com","subject":"Re: [PATCH] clone: don't use an integer as a NULL pointer","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-05-25T23:30:50Z","receivedAt":"2016-05-25T23:30:50Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/submodule-default-paths' branch, could\n> you please squash this into the relevant patch. (commit 8efbe28b,\n> \"clone: add --init-submodule=<pathspec> switch\", 23-05-2016).\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n\nThanks for pointing out!\n\nI am sorry for having you write me these emails;\nOut of curiosity, how much of this is manual work and how\nmuch did you automate of this?\n\n>\n>  builtin/clone.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/clone.c b/builtin/clone.c\n> index 22b6eac..a056f72 100644\n> --- a/builtin/clone.c\n> +++ b/builtin/clone.c\n> @@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n>                 struct strbuf sb = STRBUF_INIT;\n>                 for_each_string_list_item(item, &init_submodules) {\n>                         strbuf_addf(&sb, \"submodule.defaultUpdatePath=%s\", item->string);\n> -                       string_list_append(&option_config, strbuf_detach(&sb, 0));\n> +                       string_list_append(&option_config, strbuf_detach(&sb, NULL));\n>                 }\n>         }\n>\n> --\n> 2.8.0\n"},{"id":"287545","messageId":"5746443B.6060006@ramsayjones.plus.com","threadId":"42451","inReplyTo":"CAGZ79kaEtayuY8ZdB5hD_uYK8qZKQ1kiP3tPchjUm4k_HuVyow@mail.gmail.com","subject":"Re: [PATCH] clone: don't use an integer as a NULL pointer","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-05-26T00:32:59Z","receivedAt":"2016-05-26T00:32:59Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 26/05/16 00:30, Stefan Beller wrote:\n> On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones\n> <ramsay@ramsayjones.plus.com> wrote:\n>>\n>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n>> ---\n>>\n>> Hi Stefan,\n>>\n>> If you need to re-roll your 'sb/submodule-default-paths' branch, could\n>> you please squash this into the relevant patch. (commit 8efbe28b,\n>> \"clone: add --init-submodule=<pathspec> switch\", 23-05-2016).\n>>\n>> Thanks!\n>>\n>> ATB,\n>> Ramsay Jones\n> \n> Thanks for pointing out!\n> \n> I am sorry for having you write me these emails;\n\nIt's no problem ...\n\n> Out of curiosity, how much of this is manual work and how\n> much did you automate of this?\n\n... because this particular problem is caught by 'make sparse'.\n\n[OK, I have to write the patch, test, etc. manually, but that's\nnot a great burden.]\n\nATB,\nRamsay Jones\n"}]}