threads / bug / 42424

[BUG?] Spaces not allowed in directory names in .git/info/attributes

Subject: [BUG?] Spaces not allowed in directory names in .git/info/attributes

## tl;dr

6 messages between May 23, 2016 and May 25, 2016.

replies: 5people: 3as markdown or json

Nathan Collins· May 23, 2016, 19:06 UTC · lore
Example session:
    $ git init test.git
    Initialized empty Git repository in /tmp/test.git/.git/
    $ cd test.git
    $ mkdir "dir name"
    $ touch dir\ name/file.txt
    $ echo "dir\\ name/file.txt -text -whitespace" >> .git/info/attributes
    $ git add dir\ name/file.txt
    name/file.txt is not a valid attribute name: .git/info/attributes:1
I'm using
    $ git --version
    git version 2.5.0
Cheers,
-nathan
Junio C Hamano· May 23, 2016, 20:30 UTC · re: Nathan Collins · lore

Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

Nathan Collins <nathan.collins@gmail.com> writes:
Show 10 quoted lines
> Example session:
>
>     $ git init test.git
>     Initialized empty Git repository in /tmp/test.git/.git/
>     $ cd test.git
>     $ mkdir "dir name"
>     $ touch dir\ name/file.txt
>     $ echo "dir\\ name/file.txt -text -whitespace" >> .git/info/attributes
>     $ git add dir\ name/file.txt
>     name/file.txt is not a valid attribute name: .git/info/attributes:1
That's because spaces are not allowed in paths there.
	echo "dir?name/file.txt -text" >.git/info/attributes
may be an easy workaround for now.
Duy Nguyen· May 24, 2016, 01:37 UTC · re: Junio C Hamano · lore

Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

On Tue, May 24, 2016 at 3:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Nathan Collins <nathan.collins@gmail.com> writes:
>
>> Example session:
>>
>>     $ git init test.git
>>     Initialized empty Git repository in /tmp/test.git/.git/
>>     $ cd test.git
>>     $ mkdir "dir name"
>>     $ touch dir\ name/file.txt
>>     $ echo "dir\\ name/file.txt -text -whitespace" >> .git/info/attributes
>>     $ git add dir\ name/file.txt
>>     name/file.txt is not a valid attribute name: .git/info/attributes:1
>
> That's because spaces are not allowed in paths there.
>
>         echo "dir?name/file.txt -text" >.git/info/attributes
>
> may be an easy workaround for now.

Maybe bring back [1] (cquoting paths) and optionally optionally with backslash escaping? The conclusion at the end of that thread seems to be "ok, we may break rare setups, we just need to be upfront about it". Another option is the pathspec way: match quotes literally as well.

[1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720
-- 
Duy
Junio C Hamano· May 24, 2016, 22:54 UTC · re: Duy Nguyen · lore

Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

Duy Nguyen <pclouds@gmail.com> writes:
> Maybe bring back [1] (cquoting paths) and optionally optionally with
> backslash escaping? The conclusion at the end of that thread seems to
> be "ok, we may break rare setups, we just need to be upfront about
> it".
Yup, even though I do not think this is something urgent.
> [1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720
Junio C Hamano· May 25, 2016, 21:56 UTC · re: Duy Nguyen · lore

Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

Duy Nguyen <pclouds@gmail.com> writes:
Show 7 quoted lines
> Maybe bring back [1] (cquoting paths) and optionally optionally with
> backslash escaping? The conclusion at the end of that thread seems to
> be "ok, we may break rare setups, we just need to be upfront about
> it". Another option is the pathspec way: match quotes literally as
> well.
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720

I coaxed the ancient patch that was done in the 1.7.2 timeperiod and will push out the result near the tip of jc/attr topic that has been cooking in 'pu'.

Thanks.
Nathan Collins· May 24, 2016, 23:30 UTC · re: Junio C Hamano · lore

Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

On Mon, May 23, 2016 at 1:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Nathan Collins <nathan.collins@gmail.com> writes:
>
>> Example session:
>>
>>     $ git init test.git
>>     Initialized empty Git repository in /tmp/test.git/.git/
>>     $ cd test.git
>>     $ mkdir "dir name"
>>     $ touch dir\ name/file.txt
>>     $ echo "dir\\ name/file.txt -text -whitespace" >> .git/info/attributes
>>     $ git add dir\ name/file.txt
>>     name/file.txt is not a valid attribute name: .git/info/attributes:1
>
> That's because spaces are not allowed in paths there.
>
>         echo "dir?name/file.txt -text" >.git/info/attributes
>
> may be an easy workaround for now.
Thanks, I'll use the workaround,
-nathan

← back to recent threads