{"thread":{"id":"42424","subject":"[BUG?] Spaces not allowed in directory names in .git/info/attributes","startedAt":"2016-05-23T19:06:27Z","lastAt":"2016-05-25T21:56:36Z","messageCount":6,"participants":["Nathan Collins","Junio C Hamano","Duy Nguyen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"287272","messageId":"CAO8RVveOwrS6+pTnHY36d1Nk_B_VJD022W9i8STnNb-KyMkqNg@mail.gmail.com","threadId":"42424","inReplyTo":null,"subject":"[BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Nathan Collins","fromEmail":"nathan.collins@gmail.com","sentAt":"2016-05-23T19:06:27Z","receivedAt":"2016-05-23T19:06:27Z","isPatch":false,"sender":{"key":"nathan.collins@gmail.com","avatar":"https://gravatar.com/avatar/ecec917e18a103ea8fa2cddf99d766caa0f52d0aef155ba715a9ada837b5c1d2?d=mp&s=160"},"body":"Example session:\n\n    $ git init test.git\n    Initialized empty Git repository in /tmp/test.git/.git/\n    $ cd test.git\n    $ mkdir \"dir name\"\n    $ touch dir\\ name/file.txt\n    $ echo \"dir\\\\ name/file.txt -text -whitespace\" >> .git/info/attributes\n    $ git add dir\\ name/file.txt\n    name/file.txt is not a valid attribute name: .git/info/attributes:1\n\nI'm using\n\n    $ git --version\n    git version 2.5.0\n\nCheers,\n\n-nathan\n"},{"id":"287310","messageId":"xmqqmvng8qle.fsf@gitster.mtv.corp.google.com","threadId":"42424","inReplyTo":"CAO8RVveOwrS6+pTnHY36d1Nk_B_VJD022W9i8STnNb-KyMkqNg@mail.gmail.com","subject":"Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-23T20:30:21Z","receivedAt":"2016-05-23T20:30:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nathan Collins <nathan.collins@gmail.com> writes:\n\n> Example session:\n>\n>     $ git init test.git\n>     Initialized empty Git repository in /tmp/test.git/.git/\n>     $ cd test.git\n>     $ mkdir \"dir name\"\n>     $ touch dir\\ name/file.txt\n>     $ echo \"dir\\\\ name/file.txt -text -whitespace\" >> .git/info/attributes\n>     $ git add dir\\ name/file.txt\n>     name/file.txt is not a valid attribute name: .git/info/attributes:1\n\nThat's because spaces are not allowed in paths there.\n\n\techo \"dir?name/file.txt -text\" >.git/info/attributes\n\nmay be an easy workaround for now.\n"},{"id":"287331","messageId":"CACsJy8DXW-K-iNO65yuzMLPZS_8+R1gsQgNftwei1XUZNxhicg@mail.gmail.com","threadId":"42424","inReplyTo":"xmqqmvng8qle.fsf@gitster.mtv.corp.google.com","subject":"Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2016-05-24T01:37:33Z","receivedAt":"2016-05-24T01:37:33Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Tue, May 24, 2016 at 3:30 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Nathan Collins <nathan.collins@gmail.com> writes:\n>\n>> Example session:\n>>\n>>     $ git init test.git\n>>     Initialized empty Git repository in /tmp/test.git/.git/\n>>     $ cd test.git\n>>     $ mkdir \"dir name\"\n>>     $ touch dir\\ name/file.txt\n>>     $ echo \"dir\\\\ name/file.txt -text -whitespace\" >> .git/info/attributes\n>>     $ git add dir\\ name/file.txt\n>>     name/file.txt is not a valid attribute name: .git/info/attributes:1\n>\n> That's because spaces are not allowed in paths there.\n>\n>         echo \"dir?name/file.txt -text\" >.git/info/attributes\n>\n> may be an easy workaround for now.\n\nMaybe bring back [1] (cquoting paths) and optionally optionally with\nbackslash escaping? The conclusion at the end of that thread seems to\nbe \"ok, we may break rare setups, we just need to be upfront about\nit\". Another option is the pathspec way: match quotes literally as\nwell.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720\n-- \nDuy\n"},{"id":"287463","messageId":"xmqqtwhn2hjl.fsf@gitster.mtv.corp.google.com","threadId":"42424","inReplyTo":"CACsJy8DXW-K-iNO65yuzMLPZS_8+R1gsQgNftwei1XUZNxhicg@mail.gmail.com","subject":"Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-24T22:54:38Z","receivedAt":"2016-05-24T22:54:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Duy Nguyen <pclouds@gmail.com> writes:\n\n> Maybe bring back [1] (cquoting paths) and optionally optionally with\n> backslash escaping? The conclusion at the end of that thread seems to\n> be \"ok, we may break rare setups, we just need to be upfront about\n> it\".\n\nYup, even though I do not think this is something urgent.\n\n> [1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720\n"},{"id":"287465","messageId":"CAO8RVve07Gvr2Bes2Dp-08_8MSQoVcBm9gjMaKTU=uAXcY_1wQ@mail.gmail.com","threadId":"42424","inReplyTo":"xmqqmvng8qle.fsf@gitster.mtv.corp.google.com","subject":"Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Nathan Collins","fromEmail":"nathan.collins@gmail.com","sentAt":"2016-05-24T23:30:35Z","receivedAt":"2016-05-24T23:30:35Z","isPatch":false,"sender":{"key":"nathan.collins@gmail.com","avatar":"https://gravatar.com/avatar/ecec917e18a103ea8fa2cddf99d766caa0f52d0aef155ba715a9ada837b5c1d2?d=mp&s=160"},"body":"On Mon, May 23, 2016 at 1:30 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Nathan Collins <nathan.collins@gmail.com> writes:\n>\n>> Example session:\n>>\n>>     $ git init test.git\n>>     Initialized empty Git repository in /tmp/test.git/.git/\n>>     $ cd test.git\n>>     $ mkdir \"dir name\"\n>>     $ touch dir\\ name/file.txt\n>>     $ echo \"dir\\\\ name/file.txt -text -whitespace\" >> .git/info/attributes\n>>     $ git add dir\\ name/file.txt\n>>     name/file.txt is not a valid attribute name: .git/info/attributes:1\n>\n> That's because spaces are not allowed in paths there.\n>\n>         echo \"dir?name/file.txt -text\" >.git/info/attributes\n>\n> may be an easy workaround for now.\n\nThanks, I'll use the workaround,\n\n-nathan\n"},{"id":"287513","messageId":"xmqqmvndztrf.fsf@gitster.mtv.corp.google.com","threadId":"42424","inReplyTo":"CACsJy8DXW-K-iNO65yuzMLPZS_8+R1gsQgNftwei1XUZNxhicg@mail.gmail.com","subject":"Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-25T21:56:36Z","receivedAt":"2016-05-25T21:56:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Duy Nguyen <pclouds@gmail.com> writes:\n\n> Maybe bring back [1] (cquoting paths) and optionally optionally with\n> backslash escaping? The conclusion at the end of that thread seems to\n> be \"ok, we may break rare setups, we just need to be upfront about\n> it\". Another option is the pathspec way: match quotes literally as\n> well.\n>\n> [1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720\n\nI coaxed the ancient patch that was done in the 1.7.2 timeperiod and\nwill push out the result near the tip of jc/attr topic that has been\ncooking in 'pu'.\n\nThanks.\n"}]}