Re: [BUG?] Spaces not allowed in directory names in .git/info/attributes

From: Duy Nguyen <pclouds@gmail.com>
Date: May 24, 2016, 01:37 UTC
Message-ID: <CACsJy8DXW-K-iNO65yuzMLPZS_8+R1gsQgNftwei1XUZNxhicg@mail.gmail.com>
In-Reply-To: <xmqqmvng8qle.fsf@gitster.mtv.corp.google.com>

On Tue, May 24, 2016 at 3:30 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Nathan Collins <nathan.collins@gmail.com> writes:
>
>> Example session:
>>
>>     $ git init test.git
>>     Initialized empty Git repository in /tmp/test.git/.git/
>>     $ cd test.git
>>     $ mkdir "dir name"
>>     $ touch dir\ name/file.txt
>>     $ echo "dir\\ name/file.txt -text -whitespace" >> .git/info/attributes
>>     $ git add dir\ name/file.txt
>>     name/file.txt is not a valid attribute name: .git/info/attributes:1
>
> That's because spaces are not allowed in paths there.
>
>         echo "dir?name/file.txt -text" >.git/info/attributes
>
> may be an easy workaround for now.

Maybe bring back [1] (cquoting paths) and optionally optionally with backslash escaping? The conclusion at the end of that thread seems to be "ok, we may break rare setups, we just need to be upfront about it". Another option is the pathspec way: match quotes literally as well.

[1] http://thread.gmane.org/gmane.comp.version-control.git/160597/focus=160720

-- 
Duy