threads / discuss / 42266

t5601-clone.sh failures

Subject: t5601-clone.sh failures

## tl;dr

3 messages between May 9, 2016 and May 9, 2016.

replies: 2people: 3as markdown or json

Armin Kunaschik· May 9, 2016, 17:10 UTC · lore

Hi list,

eight t5601 tests don't run with my version of sed. The reason is a trailing space in the sed expression. See below:

#IPv6
for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]:
[user@::1] [user@::1]:
do
        ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
        test_expect_success "clone ssh://$tuah/home/user/repo" "
          test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
        "
done

I can not imagine a reason why there should be a space character... The tests run fine here without the space. When there isn't any reason, the trailing space should be removed.

Armin

tboegi@web.de· May 9, 2016, 17:53 UTC · re: Armin Kunaschik · lore

[PATCH v1 1/1] t5601: Remove trailing space in sed expression

From: Torsten Bögershausen <tboegi@web.de>

The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong sed expression, which doesn't work under all versions of sed.

Reported-By: Armin Kunaschik <megabreit@googlemail.com>
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/t5601-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
index 150aeaf..a433394 100755
--- a/t/t5601-clone.sh
+++ b/t/t5601-clone.sh
@@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '
 #IPv6
 for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:
 do
-	ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
+	ehost=$(echo $tuah | sed -e "s/1]:/1]/" | tr -d "[]")
 	test_expect_success "clone ssh://$tuah/home/user/repo" "
 	  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
 	"

-- 
2.0.0.rc1.6318.g0c2c796

Junio C Hamano· May 9, 2016, 18:38 UTC · re: tboegi@web.de · lore

Re: [PATCH v1 1/1] t5601: Remove trailing space in sed expression

tboegi@web.de writes:

Show 8 quoted lines

> From: Torsten Bögershausen <tboegi@web.de>
>
> The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong
> sed expression, which doesn't work under all versions of sed.
>
> Reported-By: Armin Kunaschik <megabreit@googlemail.com>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Good.  Thanks.

Show 16 quoted lines

>  t/t5601-clone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 150aeaf..a433394 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '
>  #IPv6
>  for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:
>  do
> -	ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
> +	ehost=$(echo $tuah | sed -e "s/1]:/1]/" | tr -d "[]")
>  	test_expect_success "clone ssh://$tuah/home/user/repo" "
>  	  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
>  	"