Re: [PATCH v1 1/1] t5601: Remove trailing space in sed expression

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2016, 18:38 UTC
Message-ID: <xmqqd1ovulev.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462816392-29561-1-git-send-email-tboegi@web.de>

tboegi@web.de writes:

Show 8 quoted lines

> From: Torsten Bögershausen <tboegi@web.de>
>
> The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong
> sed expression, which doesn't work under all versions of sed.
>
> Reported-By: Armin Kunaschik <megabreit@googlemail.com>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Good.  Thanks.

Show 16 quoted lines

>  t/t5601-clone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 150aeaf..a433394 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '
>  #IPv6
>  for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:
>  do
> -	ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
> +	ehost=$(echo $tuah | sed -e "s/1]:/1]/" | tr -d "[]")
>  	test_expect_success "clone ssh://$tuah/home/user/repo" "
>  	  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
>  	"