{"thread":{"id":"42266","subject":"t5601-clone.sh failures","startedAt":"2016-05-09T17:10:22Z","lastAt":"2016-05-09T18:38:16Z","messageCount":3,"participants":["Armin Kunaschik","tboegi@web.de","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"285942","messageId":"CALR6jEhTTo-6fgy3_TnGseXJr2OZM+cK+t4BCVEzpCZNfhn5Bg@mail.gmail.com","threadId":"42266","inReplyTo":null,"subject":"t5601-clone.sh failures","fromName":"Armin Kunaschik","fromEmail":"megabreit@googlemail.com","sentAt":"2016-05-09T17:10:22Z","receivedAt":"2016-05-09T17:10:22Z","isPatch":false,"sender":{"key":"megabreit@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/10429218?v=4"},"body":"Hi list,\n\neight t5601 tests don't run with my version of sed.\nThe reason is a trailing space in the sed expression. See below:\n\n#IPv6\nfor tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]:\n[user@::1] [user@::1]:\ndo\n        ehost=$(echo $tuah | sed -e \"s/1]:/1]/ \"| tr -d \"[]\")\n        test_expect_success \"clone ssh://$tuah/home/user/repo\" \"\n          test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo\n        \"\ndone\n\nI can not imagine a reason why there should be a space character...\nThe tests run fine here without the space.\nWhen there isn't any reason, the trailing space should be removed.\n\nArmin\n"},{"id":"285949","messageId":"1462816392-29561-1-git-send-email-tboegi@web.de","threadId":"42266","inReplyTo":"CALR6jEhTTo-6fgy3_TnGseXJr2OZM+cK+t4BCVEzpCZNfhn5Bg@mail.gmail.com","subject":"[PATCH v1 1/1] t5601: Remove trailing space in sed expression","fromName":"","fromEmail":"tboegi@web.de","sentAt":"2016-05-09T17:53:12Z","receivedAt":"2016-05-09T17:53:12Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"From: Torsten Bögershausen <tboegi@web.de>\n\nThe sed expression for IPv6, \"Tested User And Host\" or \"tuah\" used a wrong\nsed expression, which doesn't work under all versions of sed.\n\nReported-By: Armin Kunaschik <megabreit@googlemail.com>\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t5601-clone.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex 150aeaf..a433394 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '\n #IPv6\n for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:\n do\n-\tehost=$(echo $tuah | sed -e \"s/1]:/1]/ \"| tr -d \"[]\")\n+\tehost=$(echo $tuah | sed -e \"s/1]:/1]/\" | tr -d \"[]\")\n \ttest_expect_success \"clone ssh://$tuah/home/user/repo\" \"\n \t  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo\n \t\"\n-- \n2.0.0.rc1.6318.g0c2c796\n"},{"id":"285959","messageId":"xmqqd1ovulev.fsf@gitster.mtv.corp.google.com","threadId":"42266","inReplyTo":"1462816392-29561-1-git-send-email-tboegi@web.de","subject":"Re: [PATCH v1 1/1] t5601: Remove trailing space in sed expression","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-09T18:38:16Z","receivedAt":"2016-05-09T18:38:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"tboegi@web.de writes:\n\n> From: Torsten Bögershausen <tboegi@web.de>\n>\n> The sed expression for IPv6, \"Tested User And Host\" or \"tuah\" used a wrong\n> sed expression, which doesn't work under all versions of sed.\n>\n> Reported-By: Armin Kunaschik <megabreit@googlemail.com>\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n> ---\n\nGood.  Thanks.\n\n>  t/t5601-clone.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\n> index 150aeaf..a433394 100755\n> --- a/t/t5601-clone.sh\n> +++ b/t/t5601-clone.sh\n> @@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '\n>  #IPv6\n>  for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:\n>  do\n> -\tehost=$(echo $tuah | sed -e \"s/1]:/1]/ \"| tr -d \"[]\")\n> +\tehost=$(echo $tuah | sed -e \"s/1]:/1]/\" | tr -d \"[]\")\n>  \ttest_expect_success \"clone ssh://$tuah/home/user/repo\" \"\n>  \t  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo\n>  \t\"\n"}]}