threads / patch / 42227

patchgitk: Makefile: create install bin directory

Subject: [PATCH] gitk: Makefile: create install bin directory

## tl;dr

2 messages between May 5, 2016 and Dec 12, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Vasco Almeida· May 5, 2016, 17:46 UTC · lore

Force creation of destination bin directory. Before this commit, gitk would fail to install if this directory didn't already exist.

Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

Show changes to Makefile +1 −0

diff --git a/Makefile b/Makefile
index 5acdc90..5bdd52a 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,7 @@ endif
 all:: gitk-wish $(ALL_MSGFILES)
 
 install:: all
+	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk
 	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'
 	$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true

-- 
2.7.3

Paul Mackerras· Dec 12, 2016, 00:01 UTC · re: Vasco Almeida · lore

Re: [PATCH] gitk: Makefile: create install bin directory

On Thu, May 05, 2016 at 05:46:32PM +0000, Vasco Almeida wrote:

> Force creation of destination bin directory. Before this commit, gitk
> would fail to install if this directory didn't already exist.
> 
> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>

Thanks, applied (with slight tweak to commit message).

Paul.