{"thread":{"id":"42227","subject":"[PATCH] gitk: Makefile: create install bin directory","startedAt":"2016-05-05T17:46:32Z","lastAt":"2016-12-12T01:58:34Z","messageCount":2,"participants":["Vasco Almeida","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"285578","messageId":"1462470392-19991-1-git-send-email-vascomalmeida@sapo.pt","threadId":"42227","inReplyTo":null,"subject":"[PATCH] gitk: Makefile: create install bin directory","fromName":"Vasco Almeida","fromEmail":"vascomalmeida@sapo.pt","sentAt":"2016-05-05T17:46:32Z","receivedAt":"2016-05-05T17:46:32Z","isPatch":true,"sender":{"key":"vascomalmeida@sapo.pt","avatar":"https://avatars.githubusercontent.com/u/9001556?v=4"},"body":"Force creation of destination bin directory. Before this commit, gitk\nwould fail to install if this directory didn't already exist.\n\nSigned-off-by: Vasco Almeida <vascomalmeida@sapo.pt>\n---\n Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Makefile b/Makefile\nindex 5acdc90..5bdd52a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -50,6 +50,7 @@ endif\n all:: gitk-wish $(ALL_MSGFILES)\n \n install:: all\n+\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'\n \t$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk\n \t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'\n \t$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n-- \n2.7.3\n"},{"id":"307479","messageId":"20161212000144.GB18316@fergus.ozlabs.ibm.com","threadId":"42227","inReplyTo":"1462470392-19991-1-git-send-email-vascomalmeida@sapo.pt","subject":"Re: [PATCH] gitk: Makefile: create install bin directory","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2016-12-12T00:01:44Z","receivedAt":"2016-12-12T01:58:34Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Thu, May 05, 2016 at 05:46:32PM +0000, Vasco Almeida wrote:\n> Force creation of destination bin directory. Before this commit, gitk\n> would fail to install if this directory didn't already exist.\n> \n> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>\n\nThanks, applied (with slight tweak to commit message).\n\nPaul.\n"}]}