# [PATCH] gitk: Makefile: create install bin directory

2 messages from 2016-05-05 to 2016-12-12. Participants: Vasco Almeida, Paul Mackerras.
Thread: https://gitlist.dev/t/42227

## Vasco Almeida, 2016-05-05 17:46

Subject: [PATCH] gitk: Makefile: create install bin directory
Message-ID: <1462470392-19991-1-git-send-email-vascomalmeida@sapo.pt>
URL: https://gitlist.dev/e/1462470392-19991-1-git-send-email-vascomalmeida%40sapo.pt

```
Force creation of destination bin directory. Before this commit, gitk
would fail to install if this directory didn't already exist.

Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 5acdc90..5bdd52a 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,7 @@ endif
 all:: gitk-wish $(ALL_MSGFILES)
 
 install:: all
+	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk
 	$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'
 	$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true
-- 
2.7.3

```

## Paul Mackerras, 2016-12-12 00:01

Subject: Re: [PATCH] gitk: Makefile: create install bin directory
Message-ID: <20161212000144.GB18316@fergus.ozlabs.ibm.com>
URL: https://gitlist.dev/e/20161212000144.GB18316%40fergus.ozlabs.ibm.com
In-Reply-To: <1462470392-19991-1-git-send-email-vascomalmeida@sapo.pt>

```
On Thu, May 05, 2016 at 05:46:32PM +0000, Vasco Almeida wrote:
> Force creation of destination bin directory. Before this commit, gitk
> would fail to install if this directory didn't already exist.
> 
> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>

Thanks, applied (with slight tweak to commit message).

Paul.

```
