{"thread":{"id":"41932","subject":"[RFC/PATCH] git.spec: fix changelog dates","startedAt":"2016-04-05T12:09:57Z","lastAt":"2016-04-05T14:17:22Z","messageCount":4,"participants":["Michael J Gruber","Remi Galan Alfonso"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"282700","messageId":"6ef7d9d87f0c14147267c44e8b382f988936875b.1459858117.git.git@drmicha.warpmail.net","threadId":"41932","inReplyTo":null,"subject":"[RFC/PATCH] git.spec: fix changelog dates","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2016-04-05T12:09:57Z","receivedAt":"2016-04-05T12:09:57Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"A few changelog entries have inconsistent dates, which rpmlint reports\nas errors.\n\nFix them based on these assumptions:\n- It's easier to mistype a number than a weekday abbreviation.\n- changelog date must be before git commit date\n- The mistyped date is just a few days off.\n\nSigned-off-by: Michael J Gruber \n---\nI dunno if this is worthwhile, but rpmlint is the first thing we tell\npackagers and reviewers to check.\n\n git.spec.in | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/git.spec.in b/git.spec.in\nindex bfd1cfb..eb581a3 100644\n--- a/git.spec.in\n+++ b/git.spec.in\n@@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT\n * Sat Jan 30 2010 Junio C Hamano \n - We don't ship Python bits until a real foreign scm interface comes.\n \n-* Mon Feb 04 2009 David J. Mellor \n+* Mon Feb 02 2009 David J. Mellor \n - fixed broken git help -w after renaming the git-core package to git.\n \n * Fri Sep 12 2008 Quy Tonthat \n@@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT\n * Thu Jun 21 2007 Shawn O. Pearce \n - Added documentation files for git-gui\n \n-* Tue May 13 2007 Quy Tonthat \n+* Sun May 13 2007 Quy Tonthat \n - Added lib files for git-gui\n - Added Documentation/technical (As needed by Git Users Manual)\n \n@@ -272,7 +272,7 @@ rm -rf $RPM_BUILD_ROOT\n * Tue Mar 27 2007 Eygene Ryabinkin \n - Added the git-p4 package: Perforce import stuff.\n \n-* Mon Feb 13 2007 Nicolas Pitre \n+* Mon Feb 12 2007 Nicolas Pitre \n - Update core package description (Git isn't as stupid as it used to be)\n \n * Mon Feb 12 2007 Junio C Hamano \n@@ -326,5 +326,5 @@ rm -rf $RPM_BUILD_ROOT\n * Thu Jul 14 2005 Eric Biederman \n - Add the man pages, and the --without docs build option\n \n-* Wed Jul 7 2005 Chris Wright \n+* Wed Jul 6 2005 Chris Wright \n - initial git spec file\n-- \n2.8.1.120.g4a400c2\n"},{"id":"282701","messageId":"833355852.2977267.1459859316816.JavaMail.zimbra@ensimag.grenoble-inp.fr","threadId":"41932","inReplyTo":"6ef7d9d87f0c14147267c44e8b382f988936875b.1459858117.git.git@drmicha.warpmail.net","subject":"Re: [RFC/PATCH] git.spec: fix changelog dates","fromName":"Remi Galan Alfonso","fromEmail":"remi.galan-alfonso@ensimag.grenoble-inp.fr","sentAt":"2016-04-05T12:28:36Z","receivedAt":"2016-04-05T12:28:36Z","isPatch":true,"sender":{"key":"remi.galan-alfonso@ensimag.grenoble-inp.fr","avatar":"https://avatars.githubusercontent.com/u/12509162?v=4"},"body":"Michael J Gruber wrote:\n> A few changelog entries have inconsistent dates, which rpmlint reports\n> as errors.\n> \n> Fix them based on these assumptions:\n> - It's easier to mistype a number than a weekday abbreviation.\n> - changelog date must be before git commit date\n> - The mistyped date is just a few days off.\n> \n> Signed-off-by: Michael J Gruber \n> ---\n> I dunno if this is worthwhile, but rpmlint is the first thing we tell\n> packagers and reviewers to check.\n> \n> git.spec.in | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/git.spec.in b/git.spec.in\n> index bfd1cfb..eb581a3 100644\n> --- a/git.spec.in\n> +++ b/git.spec.in\n> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT\n> * Sat Jan 30 2010 Junio C Hamano \n> - We don't ship Python bits until a real foreign scm interface comes.\n> \n> -* Mon Feb 04 2009 David J. Mellor \n> +* Mon Feb 02 2009 David J. Mellor \n> - fixed broken git help -w after renaming the git-core package to git.\n> \n> * Fri Sep 12 2008 Quy Tonthat \n> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT\n> * Thu Jun 21 2007 Shawn O. Pearce \n> - Added documentation files for git-gui\n> \n> -* Tue May 13 2007 Quy Tonthat \n> +* Sun May 13 2007 Quy Tonthat \n\nIt is inconsistent with what you said in the commit message (\"It's\neasier to mistype a number than a weekday abbreviation.\").\n\nFollowing that logic, it should be:\n\t* Tue May 15 2007 Quy Tonthat \n\n(or 08, I didn't check the condition \"changelog date must be before\ngit commit date\")\n\nThanks,\nRémi\n"},{"id":"282703","messageId":"5703C084.1040405@drmicha.warpmail.net","threadId":"41932","inReplyTo":"833355852.2977267.1459859316816.JavaMail.zimbra@ensimag.grenoble-inp.fr","subject":"Re: [RFC/PATCH] git.spec: fix changelog dates","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2016-04-05T13:41:24Z","receivedAt":"2016-04-05T13:41:24Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:\n> Michael J Gruber wrote:\n>> A few changelog entries have inconsistent dates, which rpmlint reports\n>> as errors.\n>>\n>> Fix them based on these assumptions:\n>> - It's easier to mistype a number than a weekday abbreviation.\n>> - changelog date must be before git commit date\n>> - The mistyped date is just a few days off.\n>>\n>> Signed-off-by: Michael J Gruber \n>> ---\n>> I dunno if this is worthwhile, but rpmlint is the first thing we tell\n>> packagers and reviewers to check.\n>>\n>> git.spec.in | 8 ++++----\n>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/git.spec.in b/git.spec.in\n>> index bfd1cfb..eb581a3 100644\n>> --- a/git.spec.in\n>> +++ b/git.spec.in\n>> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT\n>> * Sat Jan 30 2010 Junio C Hamano \n>> - We don't ship Python bits until a real foreign scm interface comes.\n>> \n>> -* Mon Feb 04 2009 David J. Mellor \n>> +* Mon Feb 02 2009 David J. Mellor \n>> - fixed broken git help -w after renaming the git-core package to git.\n>> \n>> * Fri Sep 12 2008 Quy Tonthat \n>> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT\n>> * Thu Jun 21 2007 Shawn O. Pearce \n>> - Added documentation files for git-gui\n>> \n>> -* Tue May 13 2007 Quy Tonthat \n>> +* Sun May 13 2007 Quy Tonthat \n> \n> It is inconsistent with what you said in the commit message (\"It's\n> easier to mistype a number than a weekday abbreviation.\").\n> \n> Following that logic, it should be:\n> \t* Tue May 15 2007 Quy Tonthat \n> \n> (or 08, I didn't check the condition \"changelog date must be before\n> git commit date\")\n\nI did.\n\nThe thing is that you can't always fulfill all of these 3 conditions.\n\"Easier\" doesn't mean that the other case is impossible, just less likely.\n\n> Thanks,\n> Rémi\n> \n"},{"id":"282704","messageId":"746021769.2985589.1459865842453.JavaMail.zimbra@ensimag.grenoble-inp.fr","threadId":"41932","inReplyTo":"5703C084.1040405@drmicha.warpmail.net","subject":"Re: [RFC/PATCH] git.spec: fix changelog dates","fromName":"Remi Galan Alfonso","fromEmail":"remi.galan-alfonso@ensimag.grenoble-inp.fr","sentAt":"2016-04-05T14:17:22Z","receivedAt":"2016-04-05T14:17:22Z","isPatch":true,"sender":{"key":"remi.galan-alfonso@ensimag.grenoble-inp.fr","avatar":"https://avatars.githubusercontent.com/u/12509162?v=4"},"body":"Michael J Gruber wrote:\n> Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:\n> > Michael J Gruber wrote:\n> >> A few changelog entries have inconsistent dates, which rpmlint reports\n> >> as errors.\n> >>\n> >> Fix them based on these assumptions:\n> >> - It's easier to mistype a number than a weekday abbreviation.\n> >> - changelog date must be before git commit date\n> >> - The mistyped date is just a few days off.\n> >>\n> >> Signed-off-by: Michael J Gruber \n> >> ---\n> >> I dunno if this is worthwhile, but rpmlint is the first thing we tell\n> >> packagers and reviewers to check.\n> >>\n> >> git.spec.in | 8 ++++----\n> >> 1 file changed, 4 insertions(+), 4 deletions(-)\n> >>\n> >> diff --git a/git.spec.in b/git.spec.in\n> >> index bfd1cfb..eb581a3 100644\n> >> --- a/git.spec.in\n> >> +++ b/git.spec.in\n> >> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT\n> >> * Sat Jan 30 2010 Junio C Hamano \n> >> - We don't ship Python bits until a real foreign scm interface comes.\n> >> \n> >> -* Mon Feb 04 2009 David J. Mellor \n> >> +* Mon Feb 02 2009 David J. Mellor \n> >> - fixed broken git help -w after renaming the git-core package to git.\n> >> \n> >> * Fri Sep 12 2008 Quy Tonthat \n> >> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT\n> >> * Thu Jun 21 2007 Shawn O. Pearce \n> >> - Added documentation files for git-gui\n> >> \n> >> -* Tue May 13 2007 Quy Tonthat \n> >> +* Sun May 13 2007 Quy Tonthat \n> >\n> > It is inconsistent with what you said in the commit message (\"It's\n> > easier to mistype a number than a weekday abbreviation.\").\n> >\n> > Following that logic, it should be:\n> > * Tue May 15 2007 Quy Tonthat \n> >\n> > (or 08, I didn't check the condition \"changelog date must be before\n> > git commit date\")\n> \n> I did.\n> \n> The thing is that you can't always fulfill all of these 3 conditions.\n> \"Easier\" doesn't mean that the other case is impossible, just less likely.\n\nAh alright. Makes sense then, it is much harder to mistype 13 from 08\nthan from 15.\n\nSorry for the noise.\n\nThanks,\nRémi\n"}]}