threads / discuss / 41915

Out Of Place Capitalization In Stash Feedback

Subject: Out Of Place Capitalization In Stash Feedback

## tl;dr

3 messages between Apr 3, 2016 and Apr 4, 2016.

replies: 2people: 2as markdown or json

Saxon Knight· Apr 3, 2016, 22:09 UTC · lore

Hello,

I recently did a git stash save "working on main", and in the feedback, I noticed that "On" was capitalized ("...state On master..."). I don't think this is intentional, so I figured I'd try to let someone know.

Here is the output (quotes included by me):

"Saved working directory and index state On master: working on main"

By the way, I love Git. Thank you to everyone who helps to make it the best VCS out there!

Sincerely, Saxon P. Knight

Saxon Knight· Apr 3, 2016, 22:15 UTC · re: Saxon Knight · lore

Re: Out Of Place Capitalization In Stash Feedback

P.S.

I suppose it would help if I added some relevant details, lol. I'm using git version 2.5.0 on 64-bit Ubuntu 15.10. Feel free to contact me for more specific details if needed.

On Sun, Apr 3, 2016 at 12:09 PM, Saxon Knight <knight.saxon@gmail.com> wrote:

Show 16 quoted lines

> Hello,
>
> I recently did a git stash save "working on main", and in the
> feedback, I noticed that "On" was capitalized ("...state On
> master...").
> I don't think this is intentional, so I figured I'd try to let someone know.
>
> Here is the output (quotes included by me):
>
> "Saved working directory and index state On master: working on main"
>
> By the way, I love Git. Thank you to everyone who helps to make it the
> best VCS out there!
>
> Sincerely,
> Saxon P. Knight

Junio C Hamano· Apr 4, 2016, 17:50 UTC · re: Saxon Knight · lore

Re: Out Of Place Capitalization In Stash Feedback

Saxon Knight <knight.saxon@gmail.com> writes:

Show 8 quoted lines

> I recently did a git stash save "working on main", and in the
> feedback, I noticed that "On" was capitalized ("...state On
> master...").
> I don't think this is intentional, so I figured I'd try to let someone know.
>
> Here is the output (quotes included by me):
>
> "Saved working directory and index state On master: working on main"

"git stash list" at this point would show

    stash@{0}: On master: working on main

In other words, the title of the stash entry is "On master: working on main", and that is what is shown in the feedback.

I guess the output could quote the title in quotes to avoid this puzzlement, i.e.

    Saved working directory and index state 'On master: working on main'

 git-stash.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-stash.sh b/git-stash.sh
index c7c65e2..6d8eb22 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -266,7 +266,7 @@ save_stash () {
 	create_stash "$stash_msg" $untracked
 	store_stash -m "$stash_msg" -q $w_commit ||
 	die "$(gettext "Cannot save the current status")"
-	say Saved working directory and index state "$stash_msg"
+	say "Saved working directory and index state '$stash_msg'"
 
 	if test -z "$patch_mode"
 	then