{"thread":{"id":"41915","subject":"Out Of Place Capitalization In Stash Feedback","startedAt":"2016-04-03T22:09:14Z","lastAt":"2016-04-04T17:50:40Z","messageCount":3,"participants":["Saxon Knight","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"282583","messageId":"CAE3c8OtZx33q+gsYFgq9Rn9EtEAnSREkxL9TkTOK_n489Yh+Ww@mail.gmail.com","threadId":"41915","inReplyTo":null,"subject":"Out Of Place Capitalization In Stash Feedback","fromName":"Saxon Knight","fromEmail":"knight.saxon@gmail.com","sentAt":"2016-04-03T22:09:14Z","receivedAt":"2016-04-03T22:09:14Z","isPatch":false,"sender":{"key":"knight.saxon@gmail.com","avatar":null},"body":"Hello,\n\nI recently did a git stash save \"working on main\", and in the\nfeedback, I noticed that \"On\" was capitalized (\"...state On\nmaster...\").\nI don't think this is intentional, so I figured I'd try to let someone know.\n\nHere is the output (quotes included by me):\n\n\"Saved working directory and index state On master: working on main\"\n\nBy the way, I love Git. Thank you to everyone who helps to make it the\nbest VCS out there!\n\nSincerely,\nSaxon P. Knight\n"},{"id":"282584","messageId":"CAE3c8OuN0k4-mrqK9zVznC3JKuXyoxFcTC3NiH9Ce5NSrDG=Dg@mail.gmail.com","threadId":"41915","inReplyTo":"CAE3c8OtZx33q+gsYFgq9Rn9EtEAnSREkxL9TkTOK_n489Yh+Ww@mail.gmail.com","subject":"Re: Out Of Place Capitalization In Stash Feedback","fromName":"Saxon Knight","fromEmail":"knight.saxon@gmail.com","sentAt":"2016-04-03T22:15:33Z","receivedAt":"2016-04-03T22:15:33Z","isPatch":false,"sender":{"key":"knight.saxon@gmail.com","avatar":null},"body":"P.S.\n\nI suppose it would help if I added some relevant details, lol.\nI'm using git version 2.5.0 on 64-bit Ubuntu 15.10.\nFeel free to contact me for more specific details if needed.\n\nOn Sun, Apr 3, 2016 at 12:09 PM, Saxon Knight <knight.saxon@gmail.com> wrote:\n> Hello,\n>\n> I recently did a git stash save \"working on main\", and in the\n> feedback, I noticed that \"On\" was capitalized (\"...state On\n> master...\").\n> I don't think this is intentional, so I figured I'd try to let someone know.\n>\n> Here is the output (quotes included by me):\n>\n> \"Saved working directory and index state On master: working on main\"\n>\n> By the way, I love Git. Thank you to everyone who helps to make it the\n> best VCS out there!\n>\n> Sincerely,\n> Saxon P. Knight\n"},{"id":"282633","messageId":"xmqq8u0t5klr.fsf@gitster.mtv.corp.google.com","threadId":"41915","inReplyTo":"CAE3c8OtZx33q+gsYFgq9Rn9EtEAnSREkxL9TkTOK_n489Yh+Ww@mail.gmail.com","subject":"Re: Out Of Place Capitalization In Stash Feedback","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-04T17:50:40Z","receivedAt":"2016-04-04T17:50:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Saxon Knight <knight.saxon@gmail.com> writes:\n\n> I recently did a git stash save \"working on main\", and in the\n> feedback, I noticed that \"On\" was capitalized (\"...state On\n> master...\").\n> I don't think this is intentional, so I figured I'd try to let someone know.\n>\n> Here is the output (quotes included by me):\n>\n> \"Saved working directory and index state On master: working on main\"\n\n\"git stash list\" at this point would show\n\n    stash@{0}: On master: working on main\n\nIn other words, the title of the stash entry is \"On master: working\non main\", and that is what is shown in the feedback.\n\nI guess the output could quote the title in quotes to avoid this\npuzzlement, i.e.\n\n    Saved working directory and index state 'On master: working on main'\n\n git-stash.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex c7c65e2..6d8eb22 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -266,7 +266,7 @@ save_stash () {\n \tcreate_stash \"$stash_msg\" $untracked\n \tstore_stash -m \"$stash_msg\" -q $w_commit ||\n \tdie \"$(gettext \"Cannot save the current status\")\"\n-\tsay Saved working directory and index state \"$stash_msg\"\n+\tsay \"Saved working directory and index state '$stash_msg'\"\n \n \tif test -z \"$patch_mode\"\n \tthen\n"}]}