Re: Out Of Place Capitalization In Stash Feedback

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2016, 17:50 UTC
Message-ID: <xmqq8u0t5klr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAE3c8OtZx33q+gsYFgq9Rn9EtEAnSREkxL9TkTOK_n489Yh+Ww@mail.gmail.com>

Saxon Knight <knight.saxon@gmail.com> writes:

Show 8 quoted lines

> I recently did a git stash save "working on main", and in the
> feedback, I noticed that "On" was capitalized ("...state On
> master...").
> I don't think this is intentional, so I figured I'd try to let someone know.
>
> Here is the output (quotes included by me):
>
> "Saved working directory and index state On master: working on main"

"git stash list" at this point would show

    stash@{0}: On master: working on main

In other words, the title of the stash entry is "On master: working on main", and that is what is shown in the feedback.

I guess the output could quote the title in quotes to avoid this puzzlement, i.e.

    Saved working directory and index state 'On master: working on main'

 git-stash.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-stash.sh b/git-stash.sh
index c7c65e2..6d8eb22 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -266,7 +266,7 @@ save_stash () {
 	create_stash "$stash_msg" $untracked
 	store_stash -m "$stash_msg" -q $w_commit ||
 	die "$(gettext "Cannot save the current status")"
-	say Saved working directory and index state "$stash_msg"
+	say "Saved working directory and index state '$stash_msg'"
 
 	if test -z "$patch_mode"
 	then