threads / patch / 41694

v2submodule-config: use hashmap_iter_first()

Subject: [PATCH v2] submodule-config: use hashmap_iter_first()

## tl;dr

4 messages between Mar 15, 2016 and Mar 15, 2016. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Alexander Kuleshov· Mar 15, 2016, 19:13 UTC · lore

from the <hashmap.h> for simplification.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Reviewed-by: Stefan Beller <sbeller@google.com>
---
Changelog: added missed Signof-off-by and function name fixed
in the commit message.

 submodule-config.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Show changes to submodule-config.c +1 −2

diff --git a/submodule-config.c b/submodule-config.c
index b82d1fb..8ac5031 100644
--- a/submodule-config.c
+++ b/submodule-config.c
@@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
 		struct hashmap_iter iter;
 		struct submodule_entry *entry;
 
-		hashmap_iter_init(&cache->for_name, &iter);
-		entry = hashmap_iter_next(&iter);
+		entry = hashmap_iter_first(&cache->for_name, &iter);
 		if (!entry)
 			return NULL;
 		return entry->config;

-- 
2.8.0.rc2.216.g1477fb2.dirty

Stefan Beller· Mar 15, 2016, 19:21 UTC · re: Alexander Kuleshov · lore

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> from the <hashmap.h> for simplification.

I think what Eric wanted to point out, was to not have a continuous sentence from commit message header to body.

Either leave the body blank (as it is obvious) or write a whole sentence there:

  [PATCH v2] submodule-config: use hashmap_iter_first()

  The hashmap API offers the `hashmap_iter_first` function as initializing and
  getting the first entry is a common pattern. Use that instead of
doing initialization
  by hand and then get the first entry.

Show 31 quoted lines

>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> Reviewed-by: Stefan Beller <sbeller@google.com>
> ---
> Changelog: added missed Signof-off-by and function name fixed
> in the commit message.
>
>  submodule-config.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/submodule-config.c b/submodule-config.c
> index b82d1fb..8ac5031 100644
> --- a/submodule-config.c
> +++ b/submodule-config.c
> @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
>                 struct hashmap_iter iter;
>                 struct submodule_entry *entry;
>
> -               hashmap_iter_init(&cache->for_name, &iter);
> -               entry = hashmap_iter_next(&iter);
> +               entry = hashmap_iter_first(&cache->for_name, &iter);
>                 if (!entry)
>                         return NULL;
>                 return entry->config;
> --
> 2.8.0.rc2.216.g1477fb2.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Eric Sunshine· Mar 15, 2016, 19:30 UTC · re: Stefan Beller · lore

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller <sbeller@google.com> wrote:

Show 6 quoted lines

> On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
>> from the <hashmap.h> for simplification.
>
> I think what Eric wanted to point out, was to not have a continuous sentence
> from commit message header to body.

Yes, thanks for clarifying that.

Show 8 quoted lines

> Either leave the body blank (as it is obvious) or write a whole sentence there:
>
>   [PATCH v2] submodule-config: use hashmap_iter_first()
>
>   The hashmap API offers the `hashmap_iter_first` function as initializing and
>   getting the first entry is a common pattern. Use that instead of
> doing initialization
>   by hand and then get the first entry.

Jeff King· Mar 15, 2016, 21:55 UTC · re: Stefan Beller · lore

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

On Tue, Mar 15, 2016 at 12:21:36PM -0700, Stefan Beller wrote:

Show 15 quoted lines

> On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
> > from the <hashmap.h> for simplification.
> 
> I think what Eric wanted to point out, was to not have a continuous sentence
> from commit message header to body.
> 
> Either leave the body blank (as it is obvious) or write a whole sentence there:
> 
>   [PATCH v2] submodule-config: use hashmap_iter_first()
> 
>   The hashmap API offers the `hashmap_iter_first` function as initializing and
>   getting the first entry is a common pattern. Use that instead of
> doing initialization
>   by hand and then get the first entry.

While we are nitpicking...:)

As a reader (either reviewing now, or looking at the change later in git-log), I think my biggest question is: why? Do we expect this to change behavior, or is this just a cleanup? There's nothing wrong with "just" a cleanup, but knowing that is the intent is helpful.

-Peff