Re: [PATCH v2] submodule-config: use hashmap_iter_first()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 15, 2016, 19:30 UTC
Message-ID: <CAPig+cRJKsdkGEr-_Z7pxKW-t9X45+Z4ZLzgk=aprMHMdmLNqg@mail.gmail.com>
In-Reply-To: <CAGZ79kZ_wbJ2MGs_E-P_0eLk3JX_0QhT1c_BxqWCS+vrg8+xwA@mail.gmail.com>

On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller <sbeller@google.com> wrote:

Show 6 quoted lines

> On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
>> from the <hashmap.h> for simplification.
>
> I think what Eric wanted to point out, was to not have a continuous sentence
> from commit message header to body.

Yes, thanks for clarifying that.

Show 8 quoted lines

> Either leave the body blank (as it is obvious) or write a whole sentence there:
>
>   [PATCH v2] submodule-config: use hashmap_iter_first()
>
>   The hashmap API offers the `hashmap_iter_first` function as initializing and
>   getting the first entry is a common pattern. Use that instead of
> doing initialization
>   by hand and then get the first entry.