# [PATCH v2] submodule-config: use hashmap_iter_first() 4 messages from 2016-03-15 to 2016-03-15. Participants: Alexander Kuleshov, Stefan Beller, Eric Sunshine, Jeff King. Thread: https://gitlist.dev/t/41694 ## Alexander Kuleshov, 2016-03-15 19:13 Subject: [PATCH v2] submodule-config: use hashmap_iter_first() Message-ID: <1458069195-20888-1-git-send-email-kuleshovmail@gmail.com> URL: https://gitlist.dev/e/1458069195-20888-1-git-send-email-kuleshovmail%40gmail.com ``` from the for simplification. Signed-off-by: Alexander Kuleshov Reviewed-by: Stefan Beller --- Changelog: added missed Signof-off-by and function name fixed in the commit message. submodule-config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/submodule-config.c b/submodule-config.c index b82d1fb..8ac5031 100644 --- a/submodule-config.c +++ b/submodule-config.c @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache, struct hashmap_iter iter; struct submodule_entry *entry; - hashmap_iter_init(&cache->for_name, &iter); - entry = hashmap_iter_next(&iter); + entry = hashmap_iter_first(&cache->for_name, &iter); if (!entry) return NULL; return entry->config; -- 2.8.0.rc2.216.g1477fb2.dirty ``` ## Stefan Beller, 2016-03-15 19:21 Subject: Re: [PATCH v2] submodule-config: use hashmap_iter_first() Message-ID: URL: https://gitlist.dev/e/CAGZ79kZ_wbJ2MGs_E-P_0eLk3JX_0QhT1c_BxqWCS%2Bvrg8%2BxwA%40mail.gmail.com In-Reply-To: <1458069195-20888-1-git-send-email-kuleshovmail@gmail.com> ``` On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov wrote: > from the for simplification. I think what Eric wanted to point out, was to not have a continuous sentence from commit message header to body. Either leave the body blank (as it is obvious) or write a whole sentence there: [PATCH v2] submodule-config: use hashmap_iter_first() The hashmap API offers the `hashmap_iter_first` function as initializing and getting the first entry is a common pattern. Use that instead of doing initialization by hand and then get the first entry. > > Signed-off-by: Alexander Kuleshov > Reviewed-by: Stefan Beller > --- > Changelog: added missed Signof-off-by and function name fixed > in the commit message. > > submodule-config.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/submodule-config.c b/submodule-config.c > index b82d1fb..8ac5031 100644 > --- a/submodule-config.c > +++ b/submodule-config.c > @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache, > struct hashmap_iter iter; > struct submodule_entry *entry; > > - hashmap_iter_init(&cache->for_name, &iter); > - entry = hashmap_iter_next(&iter); > + entry = hashmap_iter_first(&cache->for_name, &iter); > if (!entry) > return NULL; > return entry->config; > -- > 2.8.0.rc2.216.g1477fb2.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Eric Sunshine, 2016-03-15 19:30 Subject: Re: [PATCH v2] submodule-config: use hashmap_iter_first() Message-ID: URL: https://gitlist.dev/e/CAPig%2BcRJKsdkGEr-_Z7pxKW-t9X45%2BZ4ZLzgk%3DaprMHMdmLNqg%40mail.gmail.com In-Reply-To: ``` On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller wrote: > On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov > wrote: >> from the for simplification. > > I think what Eric wanted to point out, was to not have a continuous sentence > from commit message header to body. Yes, thanks for clarifying that. > Either leave the body blank (as it is obvious) or write a whole sentence there: > > [PATCH v2] submodule-config: use hashmap_iter_first() > > The hashmap API offers the `hashmap_iter_first` function as initializing and > getting the first entry is a common pattern. Use that instead of > doing initialization > by hand and then get the first entry. ``` ## Jeff King, 2016-03-15 21:55 Subject: Re: [PATCH v2] submodule-config: use hashmap_iter_first() Message-ID: <20160315215524.GB30011@sigill.intra.peff.net> URL: https://gitlist.dev/e/20160315215524.GB30011%40sigill.intra.peff.net In-Reply-To: ``` On Tue, Mar 15, 2016 at 12:21:36PM -0700, Stefan Beller wrote: > On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov > wrote: > > from the for simplification. > > I think what Eric wanted to point out, was to not have a continuous sentence > from commit message header to body. > > Either leave the body blank (as it is obvious) or write a whole sentence there: > > [PATCH v2] submodule-config: use hashmap_iter_first() > > The hashmap API offers the `hashmap_iter_first` function as initializing and > getting the first entry is a common pattern. Use that instead of > doing initialization > by hand and then get the first entry. While we are nitpicking...:) As a reader (either reviewing now, or looking at the change later in git-log), I think my biggest question is: why? Do we expect this to change behavior, or is this just a cleanup? There's nothing wrong with "just" a cleanup, but knowing that is the intent is helpful. -Peff ```