threads / patch / 41670

patcht/t7502-commit.sh : remove a repeated test

Subject: [PATCH] t/t7502-commit.sh : remove a repeated test

## tl;dr

3 messages between Mar 10, 2016 and Mar 10, 2016. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Pranit Bauva· Mar 10, 2016, 22:51 UTC · lore

This extra test was introducted in the commit f9c01817

Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
---
 t/t7502-commit.sh | 5 -----
 1 file changed, 5 deletions(-)

Show changes to t/t7502-commit.sh +0 −6

diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
index b39e313..725687d 100755
--- a/t/t7502-commit.sh
+++ b/t/t7502-commit.sh
@@ -527,11 +527,6 @@ try_commit_status_combo () {
 		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 	'
 
-	test_expect_success 'commit' '
-		try_commit "" &&
-		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
-	'
-
 	test_expect_success 'commit --status' '
 		try_commit --status &&
 		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG

--
https://github.com/git/git/pull/207

Eric Sunshine· Mar 10, 2016, 23:21 UTC · re: Pranit Bauva · lore

Re: [PATCH] t/t7502-commit.sh : remove a repeated test

On Thu, Mar 10, 2016 at 5:51 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:

> t/t7502-commit.sh : remove a repeated test

Or:

    t7502: drop duplicate test

> This extra test was introducted in the commit f9c01817

We normally add some parenthetical context when mentioning commits:

    This extra test was introduced erroneously by
    f9c0181 (t7502: test commit.status, --status and
    --no-status, 2010-01-13)

The patch itself makes sense. Thanks.

Show 23 quoted lines

> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---
>  t/t7502-commit.sh | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index b39e313..725687d 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -527,11 +527,6 @@ try_commit_status_combo () {
>                 test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>         '
>
> -       test_expect_success 'commit' '
> -               try_commit "" &&
> -               test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
> -       '
> -
>         test_expect_success 'commit --status' '
>                 try_commit --status &&
>                 test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>
> --

Pranit Bauva· Mar 10, 2016, 23:26 UTC · re: Eric Sunshine · lore

Re: [PATCH] t/t7502-commit.sh : remove a repeated test

On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 6 quoted lines

>> t/t7502-commit.sh : remove a repeated test
>
> Or:
>
>     t7502: drop duplicate test
>

Sure!

Show 7 quoted lines

>> This extra test was introducted in the commit f9c01817
>
> We normally add some parenthetical context when mentioning commits:
>
>     This extra test was introduced erroneously by
>     f9c0181 (t7502: test commit.status, --status and
>     --no-status, 2010-01-13)

Seems like I have to yet get comfortable with the language used here. I will start reading more commits and stuff.

I will resend the patch with the specified edits.