{"thread":{"id":"41670","subject":"[PATCH] t/t7502-commit.sh : remove a repeated test","startedAt":"2016-03-10T22:51:33Z","lastAt":"2016-03-10T23:26:46Z","messageCount":3,"participants":["Pranit Bauva","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"280595","messageId":"0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000@eu-west-1.amazonses.com","threadId":"41670","inReplyTo":null,"subject":"[PATCH] t/t7502-commit.sh : remove a repeated test","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@gmail.com","sentAt":"2016-03-10T22:51:33Z","receivedAt":"2016-03-10T22:51:33Z","isPatch":true,"sender":{"key":"pranit.bauva@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2959938?v=4"},"body":"This extra test was introducted in the commit f9c01817\n\nSigned-off-by: Pranit Bauva <pranit.bauva@gmail.com>\n---\n t/t7502-commit.sh | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/t/t7502-commit.sh b/t/t7502-commit.sh\nindex b39e313..725687d 100755\n--- a/t/t7502-commit.sh\n+++ b/t/t7502-commit.sh\n@@ -527,11 +527,6 @@ try_commit_status_combo () {\n \t\ttest_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n \t'\n \n-\ttest_expect_success 'commit' '\n-\t\ttry_commit \"\" &&\n-\t\ttest_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n-\t'\n-\n \ttest_expect_success 'commit --status' '\n \t\ttry_commit --status &&\n \t\ttest_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n\n--\nhttps://github.com/git/git/pull/207\n"},{"id":"280596","messageId":"CAPig+cQbT3R_t=OfaueYZe2YQEdDbZWtyUFf-k=2_5S6vJuyMw@mail.gmail.com","threadId":"41670","inReplyTo":"0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] t/t7502-commit.sh : remove a repeated test","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-03-10T23:21:44Z","receivedAt":"2016-03-10T23:21:44Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Mar 10, 2016 at 5:51 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:\n> t/t7502-commit.sh : remove a repeated test\n\nOr:\n\n    t7502: drop duplicate test\n\n> This extra test was introducted in the commit f9c01817\n\nWe normally add some parenthetical context when mentioning commits:\n\n    This extra test was introduced erroneously by\n    f9c0181 (t7502: test commit.status, --status and\n    --no-status, 2010-01-13)\n\nThe patch itself makes sense. Thanks.\n\n> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>\n> ---\n>  t/t7502-commit.sh | 5 -----\n>  1 file changed, 5 deletions(-)\n>\n> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh\n> index b39e313..725687d 100755\n> --- a/t/t7502-commit.sh\n> +++ b/t/t7502-commit.sh\n> @@ -527,11 +527,6 @@ try_commit_status_combo () {\n>                 test_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n>         '\n>\n> -       test_expect_success 'commit' '\n> -               try_commit \"\" &&\n> -               test_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n> -       '\n> -\n>         test_expect_success 'commit --status' '\n>                 try_commit --status &&\n>                 test_i18ngrep \"^# Changes to be committed:\" .git/COMMIT_EDITMSG\n>\n> --\n"},{"id":"280597","messageId":"CAFZEwPM0y6oX5=1kBZiomVhqr2Dzbhp09m7YOT9rh0hrb2Kn9Q@mail.gmail.com","threadId":"41670","inReplyTo":"CAPig+cQbT3R_t=OfaueYZe2YQEdDbZWtyUFf-k=2_5S6vJuyMw@mail.gmail.com","subject":"Re: [PATCH] t/t7502-commit.sh : remove a repeated test","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@gmail.com","sentAt":"2016-03-10T23:26:46Z","receivedAt":"2016-03-10T23:26:46Z","isPatch":true,"sender":{"key":"pranit.bauva@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2959938?v=4"},"body":"On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:\n>> t/t7502-commit.sh : remove a repeated test\n>\n> Or:\n>\n>     t7502: drop duplicate test\n>\n\nSure!\n\n>> This extra test was introducted in the commit f9c01817\n>\n> We normally add some parenthetical context when mentioning commits:\n>\n>     This extra test was introduced erroneously by\n>     f9c0181 (t7502: test commit.status, --status and\n>     --no-status, 2010-01-13)\n\nSeems like I have to yet get comfortable with the language used here.\nI will start reading more commits and stuff.\n\nI will resend the patch with the specified edits.\n"}]}