# [PATCH] t/t7502-commit.sh : remove a repeated test 3 messages from 2016-03-10 to 2016-03-10. Participants: Pranit Bauva, Eric Sunshine. Thread: https://gitlist.dev/t/41670 ## Pranit Bauva, 2016-03-10 22:51 Subject: [PATCH] t/t7502-commit.sh : remove a repeated test Message-ID: <0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000%40eu-west-1.amazonses.com ``` This extra test was introducted in the commit f9c01817 Signed-off-by: Pranit Bauva --- t/t7502-commit.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh index b39e313..725687d 100755 --- a/t/t7502-commit.sh +++ b/t/t7502-commit.sh @@ -527,11 +527,6 @@ try_commit_status_combo () { test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG ' - test_expect_success 'commit' ' - try_commit "" && - test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG - ' - test_expect_success 'commit --status' ' try_commit --status && test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG -- https://github.com/git/git/pull/207 ``` ## Eric Sunshine, 2016-03-10 23:21 Subject: Re: [PATCH] t/t7502-commit.sh : remove a repeated test Message-ID: URL: https://gitlist.dev/e/CAPig%2BcQbT3R_t%3DOfaueYZe2YQEdDbZWtyUFf-k%3D2_5S6vJuyMw%40mail.gmail.com In-Reply-To: <0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000@eu-west-1.amazonses.com> ``` On Thu, Mar 10, 2016 at 5:51 PM, Pranit Bauva wrote: > t/t7502-commit.sh : remove a repeated test Or: t7502: drop duplicate test > This extra test was introducted in the commit f9c01817 We normally add some parenthetical context when mentioning commits: This extra test was introduced erroneously by f9c0181 (t7502: test commit.status, --status and --no-status, 2010-01-13) The patch itself makes sense. Thanks. > Signed-off-by: Pranit Bauva > --- > t/t7502-commit.sh | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh > index b39e313..725687d 100755 > --- a/t/t7502-commit.sh > +++ b/t/t7502-commit.sh > @@ -527,11 +527,6 @@ try_commit_status_combo () { > test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG > ' > > - test_expect_success 'commit' ' > - try_commit "" && > - test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG > - ' > - > test_expect_success 'commit --status' ' > try_commit --status && > test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG > > -- ``` ## Pranit Bauva, 2016-03-10 23:26 Subject: Re: [PATCH] t/t7502-commit.sh : remove a repeated test Message-ID: URL: https://gitlist.dev/e/CAFZEwPM0y6oX5%3D1kBZiomVhqr2Dzbhp09m7YOT9rh0hrb2Kn9Q%40mail.gmail.com In-Reply-To: ``` On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine wrote: >> t/t7502-commit.sh : remove a repeated test > > Or: > > t7502: drop duplicate test > Sure! >> This extra test was introducted in the commit f9c01817 > > We normally add some parenthetical context when mentioning commits: > > This extra test was introduced erroneously by > f9c0181 (t7502: test commit.status, --status and > --no-status, 2010-01-13) Seems like I have to yet get comfortable with the language used here. I will start reading more commits and stuff. I will resend the patch with the specified edits. ```