Re: [PATCH v1] git-p4: fix AsciiDoc formatting
On 14 March 2016 at 03:51, Junio C Hamano <gitster@pobox.com> wrote:
Show 32 quoted lines
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>>> index 738cfde..140fc12 100644
>>> --- a/Documentation/git-p4.txt
>>> +++ b/Documentation/git-p4.txt
>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>>> git config git-p4.largeFileSystem GitLFS
>>> -------------
>>> +
>>> - [1] https://git-lfs.github.com/
>>> +[1] https://git-lfs.github.com/
>>>
>>> git-p4.largeFileExtensions::
>>> All files matching a file extension in the list will be processed
>>> --
>>> 2.5.1
>>>
>>
>> Is there any chance to get this in? The formatting error is quite obvious here:
>> https://git-scm.com/docs/git-p4
>>
>> (while looking at this website I also noticed wrong double quotes around cp1252
>> which I will fix with a subsequent patch)
>
> I ignored this when I saw it first, primarily because I assumed that
> anything related to git-p4 would get a review by somebody better
> versed with git-p4 before I get to it; I forgot about the patch
> after it was buried in the other messages without anything
> happening.
>
> Will take a look.
Comparing with the git-bisect-lk2009 page, it uses a slightly different approach for external HTTP references. The references are put at the end, as internal hyperlinks, and in a bulleted list. It would make sense to try to be consistent with that, unless there's a good reason not to.
Luke
larsxschneider@gmail.com
