# [PATCH v1] git-p4: fix AsciiDoc formatting 5 messages from 2016-03-01 to 2016-03-15. Participants: larsxschneider@gmail.com, Lars Schneider, Junio C Hamano, Luke Diamand. Thread: https://gitlist.dev/t/41578 ## larsxschneider@gmail.com, 2016-03-01 11:05 Subject: [PATCH v1] git-p4: fix AsciiDoc formatting Message-ID: <1456830320-40411-1-git-send-email-larsxschneider@gmail.com> URL: https://gitlist.dev/e/1456830320-40411-1-git-send-email-larsxschneider%40gmail.com ``` From: Lars Schneider Noticed-by: Eric Sunshine Signed-off-by: Lars Schneider --- Documentation/git-p4.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt index 738cfde..140fc12 100644 --- a/Documentation/git-p4.txt +++ b/Documentation/git-p4.txt @@ -528,7 +528,7 @@ git-p4.largeFileSystem:: git config git-p4.largeFileSystem GitLFS ------------- + - [1] https://git-lfs.github.com/ +[1] https://git-lfs.github.com/ git-p4.largeFileExtensions:: All files matching a file extension in the list will be processed -- 2.5.1 ``` ## Lars Schneider, 2016-03-13 17:46 Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting Message-ID: URL: https://gitlist.dev/e/F0F4FA8A-EB42-4990-A90E-6C9245E0A9DE%40gmail.com In-Reply-To: <1456830320-40411-1-git-send-email-larsxschneider@gmail.com> ``` On 01 Mar 2016, at 12:05, larsxschneider@gmail.com wrote: > From: Lars Schneider > > Noticed-by: Eric Sunshine > Signed-off-by: Lars Schneider > --- > Documentation/git-p4.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt > index 738cfde..140fc12 100644 > --- a/Documentation/git-p4.txt > +++ b/Documentation/git-p4.txt > @@ -528,7 +528,7 @@ git-p4.largeFileSystem:: > git config git-p4.largeFileSystem GitLFS > ------------- > + > - [1] https://git-lfs.github.com/ > +[1] https://git-lfs.github.com/ > > git-p4.largeFileExtensions:: > All files matching a file extension in the list will be processed > -- > 2.5.1 > Is there any chance to get this in? The formatting error is quite obvious here: https://git-scm.com/docs/git-p4 (while looking at this website I also noticed wrong double quotes around cp1252 which I will fix with a subsequent patch) Thanks, Lars ``` ## Junio C Hamano, 2016-03-14 03:51 Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting Message-ID: URL: https://gitlist.dev/e/xmqq1t7dafa3.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Lars Schneider writes: >> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt >> index 738cfde..140fc12 100644 >> --- a/Documentation/git-p4.txt >> +++ b/Documentation/git-p4.txt >> @@ -528,7 +528,7 @@ git-p4.largeFileSystem:: >> git config git-p4.largeFileSystem GitLFS >> ------------- >> + >> - [1] https://git-lfs.github.com/ >> +[1] https://git-lfs.github.com/ >> >> git-p4.largeFileExtensions:: >> All files matching a file extension in the list will be processed >> -- >> 2.5.1 >> > > Is there any chance to get this in? The formatting error is quite obvious here: > https://git-scm.com/docs/git-p4 > > (while looking at this website I also noticed wrong double quotes around cp1252 > which I will fix with a subsequent patch) I ignored this when I saw it first, primarily because I assumed that anything related to git-p4 would get a review by somebody better versed with git-p4 before I get to it; I forgot about the patch after it was buried in the other messages without anything happening. Will take a look. Thanks. ``` ## Luke Diamand, 2016-03-15 08:38 Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting Message-ID: URL: https://gitlist.dev/e/CAE5ih79btHY33vrmSt70kkttMdFRzG-tHBZ9K3fEC_OdAZygKg%40mail.gmail.com In-Reply-To: ``` On 14 March 2016 at 03:51, Junio C Hamano wrote: > Lars Schneider writes: > >>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt >>> index 738cfde..140fc12 100644 >>> --- a/Documentation/git-p4.txt >>> +++ b/Documentation/git-p4.txt >>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem:: >>> git config git-p4.largeFileSystem GitLFS >>> ------------- >>> + >>> - [1] https://git-lfs.github.com/ >>> +[1] https://git-lfs.github.com/ >>> >>> git-p4.largeFileExtensions:: >>> All files matching a file extension in the list will be processed >>> -- >>> 2.5.1 >>> >> >> Is there any chance to get this in? The formatting error is quite obvious here: >> https://git-scm.com/docs/git-p4 >> >> (while looking at this website I also noticed wrong double quotes around cp1252 >> which I will fix with a subsequent patch) > > I ignored this when I saw it first, primarily because I assumed that > anything related to git-p4 would get a review by somebody better > versed with git-p4 before I get to it; I forgot about the patch > after it was buried in the other messages without anything > happening. > > Will take a look. Comparing with the git-bisect-lk2009 page, it uses a slightly different approach for external HTTP references. The references are put at the end, as internal hyperlinks, and in a bulleted list. It would make sense to try to be consistent with that, unless there's a good reason not to. Luke ``` ## Lars Schneider, 2016-03-15 09:09 Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting Message-ID: <6B365D58-9788-4B2F-88B0-4F8AC10321DB@gmail.com> URL: https://gitlist.dev/e/6B365D58-9788-4B2F-88B0-4F8AC10321DB%40gmail.com In-Reply-To: ``` > On 15 Mar 2016, at 09:38, Luke Diamand wrote: > > On 14 March 2016 at 03:51, Junio C Hamano wrote: >> Lars Schneider writes: >> >>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt >>>> index 738cfde..140fc12 100644 >>>> --- a/Documentation/git-p4.txt >>>> +++ b/Documentation/git-p4.txt >>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem:: >>>> git config git-p4.largeFileSystem GitLFS >>>> ------------- >>>> + >>>> - [1] https://git-lfs.github.com/ >>>> +[1] https://git-lfs.github.com/ >>>> >>>> git-p4.largeFileExtensions:: >>>> All files matching a file extension in the list will be processed >>>> -- >>>> 2.5.1 >>>> >>> >>> Is there any chance to get this in? The formatting error is quite obvious here: >>> https://git-scm.com/docs/git-p4 >>> >>> (while looking at this website I also noticed wrong double quotes around cp1252 >>> which I will fix with a subsequent patch) >> >> I ignored this when I saw it first, primarily because I assumed that >> anything related to git-p4 would get a review by somebody better >> versed with git-p4 before I get to it; I forgot about the patch >> after it was buried in the other messages without anything >> happening. >> >> Will take a look. > > Comparing with the git-bisect-lk2009 page, it uses a slightly > different approach for external HTTP references. The references are > put at the end, as internal hyperlinks, and in a bulleted list. It > would make sense to try to be consistent with that, unless there's a > good reason not to. Right! Thanks for the hint! I will post a reroll soonish. Thanks, Lars ```