{"thread":{"id":"41578","subject":"[PATCH v1] git-p4: fix AsciiDoc formatting","startedAt":"2016-03-01T11:05:20Z","lastAt":"2016-03-15T09:09:24Z","messageCount":5,"participants":["larsxschneider@gmail.com","Lars Schneider","Junio C Hamano","Luke Diamand"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"279948","messageId":"1456830320-40411-1-git-send-email-larsxschneider@gmail.com","threadId":"41578","inReplyTo":null,"subject":"[PATCH v1] git-p4: fix AsciiDoc formatting","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-01T11:05:20Z","receivedAt":"2016-03-01T11:05:20Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nNoticed-by: Eric Sunshine \nSigned-off-by: Lars Schneider \n---\n Documentation/git-p4.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\nindex 738cfde..140fc12 100644\n--- a/Documentation/git-p4.txt\n+++ b/Documentation/git-p4.txt\n@@ -528,7 +528,7 @@ git-p4.largeFileSystem::\n git config git-p4.largeFileSystem GitLFS\n -------------\n +\n-\t[1] https://git-lfs.github.com/\n+[1] https://git-lfs.github.com/\n\n git-p4.largeFileExtensions::\n \tAll files matching a file extension in the list will be processed\n--\n2.5.1\n"},{"id":"280687","messageId":"F0F4FA8A-EB42-4990-A90E-6C9245E0A9DE@gmail.com","threadId":"41578","inReplyTo":"1456830320-40411-1-git-send-email-larsxschneider@gmail.com","subject":"Re: [PATCH v1] git-p4: fix AsciiDoc formatting","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-13T17:46:36Z","receivedAt":"2016-03-13T17:46:36Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\nOn 01 Mar 2016, at 12:05, larsxschneider@gmail.com wrote:\n\n> From: Lars Schneider \n> \n> Noticed-by: Eric Sunshine \n> Signed-off-by: Lars Schneider \n> ---\n> Documentation/git-p4.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\n> index 738cfde..140fc12 100644\n> --- a/Documentation/git-p4.txt\n> +++ b/Documentation/git-p4.txt\n> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::\n> git config git-p4.largeFileSystem GitLFS\n> -------------\n> +\n> -\t[1] https://git-lfs.github.com/\n> +[1] https://git-lfs.github.com/\n> \n> git-p4.largeFileExtensions::\n> \tAll files matching a file extension in the list will be processed\n> --\n> 2.5.1\n> \n\nIs there any chance to get this in? The formatting error is quite obvious here:\nhttps://git-scm.com/docs/git-p4\n\n(while looking at this website I also noticed wrong double quotes around cp1252\nwhich I will fix with a subsequent patch)\n\nThanks,\nLars"},{"id":"280695","messageId":"xmqq1t7dafa3.fsf@gitster.mtv.corp.google.com","threadId":"41578","inReplyTo":"F0F4FA8A-EB42-4990-A90E-6C9245E0A9DE@gmail.com","subject":"Re: [PATCH v1] git-p4: fix AsciiDoc formatting","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-14T03:51:00Z","receivedAt":"2016-03-14T03:51:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider writes:\n\n>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\n>> index 738cfde..140fc12 100644\n>> --- a/Documentation/git-p4.txt\n>> +++ b/Documentation/git-p4.txt\n>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::\n>> git config git-p4.largeFileSystem GitLFS\n>> -------------\n>> +\n>> -\t[1] https://git-lfs.github.com/\n>> +[1] https://git-lfs.github.com/\n>> \n>> git-p4.largeFileExtensions::\n>> \tAll files matching a file extension in the list will be processed\n>> --\n>> 2.5.1\n>> \n>\n> Is there any chance to get this in? The formatting error is quite obvious here:\n> https://git-scm.com/docs/git-p4\n>\n> (while looking at this website I also noticed wrong double quotes around cp1252\n> which I will fix with a subsequent patch)\n\nI ignored this when I saw it first, primarily because I assumed that\nanything related to git-p4 would get a review by somebody better\nversed with git-p4 before I get to it; I forgot about the patch\nafter it was buried in the other messages without anything\nhappening.\n\nWill take a look.\n\nThanks.\n"},{"id":"280769","messageId":"CAE5ih79btHY33vrmSt70kkttMdFRzG-tHBZ9K3fEC_OdAZygKg@mail.gmail.com","threadId":"41578","inReplyTo":"xmqq1t7dafa3.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v1] git-p4: fix AsciiDoc formatting","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2016-03-15T08:38:36Z","receivedAt":"2016-03-15T08:38:36Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"On 14 March 2016 at 03:51, Junio C Hamano wrote:\n> Lars Schneider writes:\n>\n>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\n>>> index 738cfde..140fc12 100644\n>>> --- a/Documentation/git-p4.txt\n>>> +++ b/Documentation/git-p4.txt\n>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::\n>>> git config git-p4.largeFileSystem GitLFS\n>>> -------------\n>>> +\n>>> - [1] https://git-lfs.github.com/\n>>> +[1] https://git-lfs.github.com/\n>>>\n>>> git-p4.largeFileExtensions::\n>>> All files matching a file extension in the list will be processed\n>>> --\n>>> 2.5.1\n>>>\n>>\n>> Is there any chance to get this in? The formatting error is quite obvious here:\n>> https://git-scm.com/docs/git-p4\n>>\n>> (while looking at this website I also noticed wrong double quotes around cp1252\n>> which I will fix with a subsequent patch)\n>\n> I ignored this when I saw it first, primarily because I assumed that\n> anything related to git-p4 would get a review by somebody better\n> versed with git-p4 before I get to it; I forgot about the patch\n> after it was buried in the other messages without anything\n> happening.\n>\n> Will take a look.\n\nComparing with the git-bisect-lk2009 page, it uses a slightly\ndifferent approach for external HTTP references. The references are\nput at the end, as internal hyperlinks, and in a bulleted list. It\nwould make sense to try to be consistent with that, unless there's a\ngood reason not to.\n\nLuke\n"},{"id":"280770","messageId":"6B365D58-9788-4B2F-88B0-4F8AC10321DB@gmail.com","threadId":"41578","inReplyTo":"CAE5ih79btHY33vrmSt70kkttMdFRzG-tHBZ9K3fEC_OdAZygKg@mail.gmail.com","subject":"Re: [PATCH v1] git-p4: fix AsciiDoc formatting","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-15T09:09:24Z","receivedAt":"2016-03-15T09:09:24Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 15 Mar 2016, at 09:38, Luke Diamand wrote:\n> \n> On 14 March 2016 at 03:51, Junio C Hamano wrote:\n>> Lars Schneider writes:\n>> \n>>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\n>>>> index 738cfde..140fc12 100644\n>>>> --- a/Documentation/git-p4.txt\n>>>> +++ b/Documentation/git-p4.txt\n>>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::\n>>>> git config git-p4.largeFileSystem GitLFS\n>>>> -------------\n>>>> +\n>>>> - [1] https://git-lfs.github.com/\n>>>> +[1] https://git-lfs.github.com/\n>>>> \n>>>> git-p4.largeFileExtensions::\n>>>> All files matching a file extension in the list will be processed\n>>>> --\n>>>> 2.5.1\n>>>> \n>>> \n>>> Is there any chance to get this in? The formatting error is quite obvious here:\n>>> https://git-scm.com/docs/git-p4\n>>> \n>>> (while looking at this website I also noticed wrong double quotes around cp1252\n>>> which I will fix with a subsequent patch)\n>> \n>> I ignored this when I saw it first, primarily because I assumed that\n>> anything related to git-p4 would get a review by somebody better\n>> versed with git-p4 before I get to it; I forgot about the patch\n>> after it was buried in the other messages without anything\n>> happening.\n>> \n>> Will take a look.\n> \n> Comparing with the git-bisect-lk2009 page, it uses a slightly\n> different approach for external HTTP references. The references are\n> put at the end, as internal hyperlinks, and in a bulleted list. It\n> would make sense to try to be consistent with that, unless there's a\n> good reason not to.\n\nRight! Thanks for the hint! I will post a reroll soonish.\n\nThanks,\nLars"}]}