threads / patch / 41300

patchgit-gui--askpass: generalize the window title

Subject: [PATCH] git-gui--askpass: generalize the window title

## tl;dr

8 messages between Feb 1, 2016 and Apr 27, 2017. Diffs are folded; open one to read it.

replies: 7people: 3as markdown or json

Sebastian Schuberth· Feb 1, 2016, 12:11 UTC · lore

From: Sebastian Schuberth <sschuberth@gmail.com>

git-gui--askpass is not only used for SSH authentication, but also for HTTPS. In that context it is confusing to have a window title of "OpenSSH". So generalize the title so that it also says which parent process, i.e. Git, requires authentication.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 git-gui/git-gui--askpass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to git-gui/git-gui--askpass +1 −2

diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..1e5c325 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -60,7 +60,7 @@ proc finish {} {
 	set ::rc 0
 }
 
-wm title . "OpenSSH"
+wm title . "Git Authentication"
 tk::PlaceWindow .
 vwait rc
 exit $rc

--
https://github.com/git/git/pull/195

Sebastian Schuberth· Feb 12, 2016, 09:26 UTC · re: Sebastian Schuberth · lore

Re: [PATCH] git-gui--askpass: generalize the window title

On 01.02.2016 13:11, Sebastian Schuberth wrote:

Show 6 quoted lines

> git-gui--askpass is not only used for SSH authentication, but also for
> HTTPS. In that context it is confusing to have a window title of
> "OpenSSH". So generalize the title so that it also says which parent
> process, i.e. Git, requires authentication.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>

I haven't seen this being picked up so far. Any comments?

-- 
Sebastian Schuberth

Sebastian Schuberth· Mar 7, 2017, 15:48 UTC · re: Sebastian Schuberth · lore

[RESEND PATCH] git-gui--askpass: generalize the window title

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 git-gui/git-gui--askpass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to git-gui/git-gui--askpass +1 −2

diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..1e5c3256 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -60,7 +60,7 @@ proc finish {} {
 	set ::rc 0
 }
 
-wm title . "OpenSSH"
+wm title . "Git Authentication"
 tk::PlaceWindow .
 vwait rc
 exit $rc

--
https://github.com/git/git/pull/195

Stefan Beller· Mar 7, 2017, 18:30 UTC · re: Sebastian Schuberth · lore

Re: [RESEND PATCH] git-gui--askpass: generalize the window title

https://public-inbox.org/git/xmqq60jz2xry.fsf@gitster.mtv.corp.google.com/

Although the following are included in git.git repository, they have their own authoritative repository and maintainers:

 - git-gui/ comes from git-gui project, maintained by Pat Thoyts:

        git://repo.or.cz/git-gui.git

I cc'd Pat.

Thanks, Stefan

Sebastian Schuberth· Mar 7, 2017, 18:40 UTC · re: Stefan Beller · lore

Re: [RESEND PATCH] git-gui--askpass: generalize the window title

On Tue, Mar 7, 2017 at 7:30 PM, Stefan Beller <sbeller@google.com> wrote:

> Although the following are included in git.git repository, they have their
> own authoritative repository and maintainers:

Thanks. I continuously get confused by this fact.

-- 
Sebastian Schuberth

Sebastian Schuberth· Apr 27, 2017, 06:38 UTC · re: Sebastian Schuberth · lore

[PATCH v2] git-gui--askpass: generalize the wording

git-gui--askpass is not only used for SSH authentication, but also for HTTPS. In that context it is confusing to only rfer to "OpenSSH", also because another SSH client like PuTTY might be in use. So generalize wording and also say which parent process, i.e. Git, requires authentication.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 git-gui/git-gui--askpass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Show changes to git-gui/git-gui--askpass +3 −4

diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
index 4277f30..4e3f00d 100755
--- a/git-gui/git-gui--askpass
+++ b/git-gui/git-gui--askpass
@@ -2,7 +2,7 @@
 # Tcl ignores the next line -*- tcl -*- \
 exec wish "$0" -- "$@"
 
-# This is a trivial implementation of an SSH_ASKPASS handler.
+# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
 # Git-gui uses this script if none are already configured.
 
 package require Tk
@@ -12,7 +12,7 @@ set yesno  0
 set rc     255
 
 if {$argc < 1} {
-	set prompt "Enter your OpenSSH passphrase:"
+	set prompt "Enter your password / passphrase:"
 } else {
 	set prompt [join $argv " "]
 	if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
@@ -60,7 +60,7 @@ proc finish {} {
 	set ::rc 0
 }
 
-wm title . "OpenSSH"
+wm title . "Git Authentication"
 tk::PlaceWindow .
 vwait rc
 exit $rc

--
https://github.com/git/git/pull/195

Sebastian Schuberth· Apr 27, 2017, 09:19 UTC · re: Sebastian Schuberth · lore

Re: [PATCH v2] git-gui--askpass: generalize the wording

+ Pat

On 2017-04-27 08:38, Sebastian Schuberth wrote:

Show 43 quoted lines

> git-gui--askpass is not only used for SSH authentication, but also for
> HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
> because another SSH client like PuTTY might be in use. So generalize
> wording and also say which parent process, i.e. Git, requires
> authentication.
> 
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
>   git-gui/git-gui--askpass | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
> index 4277f30..4e3f00d 100755
> --- a/git-gui/git-gui--askpass
> +++ b/git-gui/git-gui--askpass
> @@ -2,7 +2,7 @@
>   # Tcl ignores the next line -*- tcl -*- \
>   exec wish "$0" -- "$@"
>   
> -# This is a trivial implementation of an SSH_ASKPASS handler.
> +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
>   # Git-gui uses this script if none are already configured.
>   
>   package require Tk
> @@ -12,7 +12,7 @@ set yesno  0
>   set rc     255
>   
>   if {$argc < 1} {
> -	set prompt "Enter your OpenSSH passphrase:"
> +	set prompt "Enter your password / passphrase:"
>   } else {
>   	set prompt [join $argv " "]
>   	if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
> @@ -60,7 +60,7 @@ proc finish {} {
>   	set ::rc 0
>   }
>   
> -wm title . "OpenSSH"
> +wm title . "Git Authentication"
>   tk::PlaceWindow .
>   vwait rc
>   exit $rc
>

-- 
Sebastian Schuberth

Johannes Schindelin· Apr 27, 2017, 14:02 UTC · re: Sebastian Schuberth · lore

Re: [PATCH v2] git-gui--askpass: generalize the wording

+ Pat

On Thu, 27 Apr 2017, Sebastian Schuberth wrote:

Show 54 quoted lines

> + Pat
> 
> On 2017-04-27 08:38, Sebastian Schuberth wrote:
> 
> > git-gui--askpass is not only used for SSH authentication, but also for
> > HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
> > because another SSH client like PuTTY might be in use. So generalize
> > wording and also say which parent process, i.e. Git, requires
> > authentication.
> > 
> > Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> > ---
> >   git-gui/git-gui--askpass | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
> > index 4277f30..4e3f00d 100755
> > --- a/git-gui/git-gui--askpass
> > +++ b/git-gui/git-gui--askpass
> > @@ -2,7 +2,7 @@
> >   # Tcl ignores the next line -*- tcl -*- \
> >   exec wish "$0" -- "$@"
> >   
> > -# This is a trivial implementation of an SSH_ASKPASS handler.
> > +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
> >   # Git-gui uses this script if none are already configured.
> >   
> >   package require Tk
> > @@ -12,7 +12,7 @@ set yesno  0
> >   set rc     255
> >   
> >   if {$argc < 1} {
> > -	set prompt "Enter your OpenSSH passphrase:"
> > +	set prompt "Enter your password / passphrase:"
> >   } else {
> >    set prompt [join $argv " "]
> >    if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
> > @@ -60,7 +60,7 @@ proc finish {} {
> >   	set ::rc 0
> >   }
> >   
> > -wm title . "OpenSSH"
> > +wm title . "Git Authentication"
> >   tk::PlaceWindow .
> >   vwait rc
> >   exit $rc
> > 
> 
> 
> -- 
> Sebastian Schuberth
> 
> 
>