{"thread":{"id":"41300","subject":"[PATCH] git-gui--askpass: generalize the window title","startedAt":"2016-02-01T12:11:05Z","lastAt":"2017-04-27T14:02:38Z","messageCount":8,"participants":["Sebastian Schuberth","Stefan Beller","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"277170","messageId":"000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com","threadId":"41300","inReplyTo":null,"subject":"[PATCH] git-gui--askpass: generalize the window title","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2016-02-01T12:11:05Z","receivedAt":"2016-02-01T12:11:05Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"From: Sebastian Schuberth <sschuberth@gmail.com>\n\ngit-gui--askpass is not only used for SSH authentication, but also for\nHTTPS. In that context it is confusing to have a window title of\n\"OpenSSH\". So generalize the title so that it also says which parent\nprocess, i.e. Git, requires authentication.\n\nSigned-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n---\n git-gui/git-gui--askpass | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass\nindex 4277f30..1e5c325 100755\n--- a/git-gui/git-gui--askpass\n+++ b/git-gui/git-gui--askpass\n@@ -60,7 +60,7 @@ proc finish {} {\n \tset ::rc 0\n }\n \n-wm title . \"OpenSSH\"\n+wm title . \"Git Authentication\"\n tk::PlaceWindow .\n vwait rc\n exit $rc\n\n--\nhttps://github.com/git/git/pull/195\n"},{"id":"278002","messageId":"56BDA546.4090808@gmail.com","threadId":"41300","inReplyTo":"000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] git-gui--askpass: generalize the window title","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2016-02-12T09:26:30Z","receivedAt":"2016-02-12T09:26:30Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On 01.02.2016 13:11, Sebastian Schuberth wrote:\n\n> git-gui--askpass is not only used for SSH authentication, but also for\n> HTTPS. In that context it is confusing to have a window title of\n> \"OpenSSH\". So generalize the title so that it also says which parent\n> process, i.e. Git, requires authentication.\n>\n> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n\nI haven't seen this being picked up so far. Any comments?\n\n-- \nSebastian Schuberth\n"},{"id":"313435","messageId":"0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com","threadId":"41300","inReplyTo":"000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com","subject":"[RESEND PATCH] git-gui--askpass: generalize the window title","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-03-07T15:48:11Z","receivedAt":"2017-03-07T18:20:06Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"git-gui--askpass is not only used for SSH authentication, but also for\nHTTPS. In that context it is confusing to have a window title of\n\"OpenSSH\". So generalize the title so that it also says which parent\nprocess, i.e. Git, requires authentication.\n\nSigned-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n---\n git-gui/git-gui--askpass | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass\nindex 4277f30..1e5c3256 100755\n--- a/git-gui/git-gui--askpass\n+++ b/git-gui/git-gui--askpass\n@@ -60,7 +60,7 @@ proc finish {} {\n \tset ::rc 0\n }\n \n-wm title . \"OpenSSH\"\n+wm title . \"Git Authentication\"\n tk::PlaceWindow .\n vwait rc\n exit $rc\n\n--\nhttps://github.com/git/git/pull/195\n"},{"id":"313436","messageId":"CAGZ79ka_5QogUEwF6SPCwyqSrCNSrtAsqzqJQdXsJkZEAyzDNA@mail.gmail.com","threadId":"41300","inReplyTo":"0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com","subject":"Re: [RESEND PATCH] git-gui--askpass: generalize the window title","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-03-07T18:30:54Z","receivedAt":"2017-03-07T18:31:08Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"https://public-inbox.org/git/xmqq60jz2xry.fsf@gitster.mtv.corp.google.com/\n\nAlthough the following are included in git.git repository, they have their\nown authoritative repository and maintainers:\n\n - git-gui/ comes from git-gui project, maintained by Pat Thoyts:\n\n        git://repo.or.cz/git-gui.git\n\n\nI cc'd Pat.\n\nThanks,\nStefan\n"},{"id":"313447","messageId":"CAHGBnuNgHbDmFj2y=4gLTeKQL+JSBazNrQSZwfN=gN3eTggz9Q@mail.gmail.com","threadId":"41300","inReplyTo":"CAGZ79ka_5QogUEwF6SPCwyqSrCNSrtAsqzqJQdXsJkZEAyzDNA@mail.gmail.com","subject":"Re: [RESEND PATCH] git-gui--askpass: generalize the window title","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-03-07T18:40:55Z","receivedAt":"2017-03-07T20:25:53Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Tue, Mar 7, 2017 at 7:30 PM, Stefan Beller <sbeller@google.com> wrote:\n\n> Although the following are included in git.git repository, they have their\n> own authoritative repository and maintainers:\n\nThanks. I continuously get confused by this fact.\n\n-- \nSebastian Schuberth\n"},{"id":"318056","messageId":"0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000@eu-west-1.amazonses.com","threadId":"41300","inReplyTo":"0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com","subject":"[PATCH v2] git-gui--askpass: generalize the wording","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-04-27T06:38:00Z","receivedAt":"2017-04-27T06:38:17Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"git-gui--askpass is not only used for SSH authentication, but also for\nHTTPS. In that context it is confusing to only rfer to \"OpenSSH\", also\nbecause another SSH client like PuTTY might be in use. So generalize\nwording and also say which parent process, i.e. Git, requires\nauthentication.\n\nSigned-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n---\n git-gui/git-gui--askpass | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass\nindex 4277f30..4e3f00d 100755\n--- a/git-gui/git-gui--askpass\n+++ b/git-gui/git-gui--askpass\n@@ -2,7 +2,7 @@\n # Tcl ignores the next line -*- tcl -*- \\\n exec wish \"$0\" -- \"$@\"\n \n-# This is a trivial implementation of an SSH_ASKPASS handler.\n+# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.\n # Git-gui uses this script if none are already configured.\n \n package require Tk\n@@ -12,7 +12,7 @@ set yesno  0\n set rc     255\n \n if {$argc < 1} {\n-\tset prompt \"Enter your OpenSSH passphrase:\"\n+\tset prompt \"Enter your password / passphrase:\"\n } else {\n \tset prompt [join $argv \" \"]\n \tif {[regexp -nocase {\\(yes\\/no\\)\\?\\s*$} $prompt]} {\n@@ -60,7 +60,7 @@ proc finish {} {\n \tset ::rc 0\n }\n \n-wm title . \"OpenSSH\"\n+wm title . \"Git Authentication\"\n tk::PlaceWindow .\n vwait rc\n exit $rc\n\n--\nhttps://github.com/git/git/pull/195\n"},{"id":"318065","messageId":"f318a3ab-930f-fa58-db3d-d28998371a86@gmail.com","threadId":"41300","inReplyTo":"0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH v2] git-gui--askpass: generalize the wording","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-04-27T09:19:04Z","receivedAt":"2017-04-27T09:19:19Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"+ Pat\n\nOn 2017-04-27 08:38, Sebastian Schuberth wrote:\n\n> git-gui--askpass is not only used for SSH authentication, but also for\n> HTTPS. In that context it is confusing to only rfer to \"OpenSSH\", also\n> because another SSH client like PuTTY might be in use. So generalize\n> wording and also say which parent process, i.e. Git, requires\n> authentication.\n> \n> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n> ---\n>   git-gui/git-gui--askpass | 6 +++---\n>   1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass\n> index 4277f30..4e3f00d 100755\n> --- a/git-gui/git-gui--askpass\n> +++ b/git-gui/git-gui--askpass\n> @@ -2,7 +2,7 @@\n>   # Tcl ignores the next line -*- tcl -*- \\\n>   exec wish \"$0\" -- \"$@\"\n>   \n> -# This is a trivial implementation of an SSH_ASKPASS handler.\n> +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.\n>   # Git-gui uses this script if none are already configured.\n>   \n>   package require Tk\n> @@ -12,7 +12,7 @@ set yesno  0\n>   set rc     255\n>   \n>   if {$argc < 1} {\n> -\tset prompt \"Enter your OpenSSH passphrase:\"\n> +\tset prompt \"Enter your password / passphrase:\"\n>   } else {\n>   \tset prompt [join $argv \" \"]\n>   \tif {[regexp -nocase {\\(yes\\/no\\)\\?\\s*$} $prompt]} {\n> @@ -60,7 +60,7 @@ proc finish {} {\n>   \tset ::rc 0\n>   }\n>   \n> -wm title . \"OpenSSH\"\n> +wm title . \"Git Authentication\"\n>   tk::PlaceWindow .\n>   vwait rc\n>   exit $rc\n> \n\n\n-- \nSebastian Schuberth\n\n"},{"id":"318068","messageId":"alpine.DEB.2.20.1704271601440.3480@virtualbox","threadId":"41300","inReplyTo":"f318a3ab-930f-fa58-db3d-d28998371a86@gmail.com","subject":"Re: [PATCH v2] git-gui--askpass: generalize the wording","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-04-27T14:02:10Z","receivedAt":"2017-04-27T14:02:38Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"+ Pat\n\n\nOn Thu, 27 Apr 2017, Sebastian Schuberth wrote:\n\n> + Pat\n> \n> On 2017-04-27 08:38, Sebastian Schuberth wrote:\n> \n> > git-gui--askpass is not only used for SSH authentication, but also for\n> > HTTPS. In that context it is confusing to only rfer to \"OpenSSH\", also\n> > because another SSH client like PuTTY might be in use. So generalize\n> > wording and also say which parent process, i.e. Git, requires\n> > authentication.\n> > \n> > Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n> > ---\n> >   git-gui/git-gui--askpass | 6 +++---\n> >   1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass\n> > index 4277f30..4e3f00d 100755\n> > --- a/git-gui/git-gui--askpass\n> > +++ b/git-gui/git-gui--askpass\n> > @@ -2,7 +2,7 @@\n> >   # Tcl ignores the next line -*- tcl -*- \\\n> >   exec wish \"$0\" -- \"$@\"\n> >   \n> > -# This is a trivial implementation of an SSH_ASKPASS handler.\n> > +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.\n> >   # Git-gui uses this script if none are already configured.\n> >   \n> >   package require Tk\n> > @@ -12,7 +12,7 @@ set yesno  0\n> >   set rc     255\n> >   \n> >   if {$argc < 1} {\n> > -\tset prompt \"Enter your OpenSSH passphrase:\"\n> > +\tset prompt \"Enter your password / passphrase:\"\n> >   } else {\n> >    set prompt [join $argv \" \"]\n> >    if {[regexp -nocase {\\(yes\\/no\\)\\?\\s*$} $prompt]} {\n> > @@ -60,7 +60,7 @@ proc finish {} {\n> >   \tset ::rc 0\n> >   }\n> >   \n> > -wm title . \"OpenSSH\"\n> > +wm title . \"Git Authentication\"\n> >   tk::PlaceWindow .\n> >   vwait rc\n> >   exit $rc\n> > \n> \n> \n> -- \n> Sebastian Schuberth\n> \n> \n> \n"}]}