# [PATCH] git-gui--askpass: generalize the window title 8 messages from 2016-02-01 to 2017-04-27. Participants: Sebastian Schuberth, Stefan Beller, Johannes Schindelin. Thread: https://gitlist.dev/t/41300 ## Sebastian Schuberth, 2016-02-01 12:11 Subject: [PATCH] git-gui--askpass: generalize the window title Message-ID: <000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000%40eu-west-1.amazonses.com ``` From: Sebastian Schuberth git-gui--askpass is not only used for SSH authentication, but also for HTTPS. In that context it is confusing to have a window title of "OpenSSH". So generalize the title so that it also says which parent process, i.e. Git, requires authentication. Signed-off-by: Sebastian Schuberth --- git-gui/git-gui--askpass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass index 4277f30..1e5c325 100755 --- a/git-gui/git-gui--askpass +++ b/git-gui/git-gui--askpass @@ -60,7 +60,7 @@ proc finish {} { set ::rc 0 } -wm title . "OpenSSH" +wm title . "Git Authentication" tk::PlaceWindow . vwait rc exit $rc -- https://github.com/git/git/pull/195 ``` ## Sebastian Schuberth, 2016-02-12 09:26 Subject: Re: [PATCH] git-gui--askpass: generalize the window title Message-ID: <56BDA546.4090808@gmail.com> URL: https://gitlist.dev/e/56BDA546.4090808%40gmail.com In-Reply-To: <000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com> ``` On 01.02.2016 13:11, Sebastian Schuberth wrote: > git-gui--askpass is not only used for SSH authentication, but also for > HTTPS. In that context it is confusing to have a window title of > "OpenSSH". So generalize the title so that it also says which parent > process, i.e. Git, requires authentication. > > Signed-off-by: Sebastian Schuberth I haven't seen this being picked up so far. Any comments? -- Sebastian Schuberth ``` ## Sebastian Schuberth, 2017-03-07 15:48 Subject: [RESEND PATCH] git-gui--askpass: generalize the window title Message-ID: <0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000%40eu-west-1.amazonses.com In-Reply-To: <000001529cbe5436-285f0113-5761-49d8-8961-5a9df0180ed7-000000@eu-west-1.amazonses.com> ``` git-gui--askpass is not only used for SSH authentication, but also for HTTPS. In that context it is confusing to have a window title of "OpenSSH". So generalize the title so that it also says which parent process, i.e. Git, requires authentication. Signed-off-by: Sebastian Schuberth --- git-gui/git-gui--askpass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass index 4277f30..1e5c3256 100755 --- a/git-gui/git-gui--askpass +++ b/git-gui/git-gui--askpass @@ -60,7 +60,7 @@ proc finish {} { set ::rc 0 } -wm title . "OpenSSH" +wm title . "Git Authentication" tk::PlaceWindow . vwait rc exit $rc -- https://github.com/git/git/pull/195 ``` ## Stefan Beller, 2017-03-07 18:30 Subject: Re: [RESEND PATCH] git-gui--askpass: generalize the window title Message-ID: URL: https://gitlist.dev/e/CAGZ79ka_5QogUEwF6SPCwyqSrCNSrtAsqzqJQdXsJkZEAyzDNA%40mail.gmail.com In-Reply-To: <0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com> ``` https://public-inbox.org/git/xmqq60jz2xry.fsf@gitster.mtv.corp.google.com/ Although the following are included in git.git repository, they have their own authoritative repository and maintainers: - git-gui/ comes from git-gui project, maintained by Pat Thoyts: git://repo.or.cz/git-gui.git I cc'd Pat. Thanks, Stefan ``` ## Sebastian Schuberth, 2017-03-07 18:40 Subject: Re: [RESEND PATCH] git-gui--askpass: generalize the window title Message-ID: URL: https://gitlist.dev/e/CAHGBnuNgHbDmFj2y%3D4gLTeKQL%2BJSBazNrQSZwfN%3DgN3eTggz9Q%40mail.gmail.com In-Reply-To: ``` On Tue, Mar 7, 2017 at 7:30 PM, Stefan Beller wrote: > Although the following are included in git.git repository, they have their > own authoritative repository and maintainers: Thanks. I continuously get confused by this fact. -- Sebastian Schuberth ``` ## Sebastian Schuberth, 2017-04-27 06:38 Subject: [PATCH v2] git-gui--askpass: generalize the wording Message-ID: <0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000%40eu-west-1.amazonses.com In-Reply-To: <0102015aa974d7a6-46afa73b-4378-4b01-9db4-723fb9e41d65-000000@eu-west-1.amazonses.com> ``` git-gui--askpass is not only used for SSH authentication, but also for HTTPS. In that context it is confusing to only rfer to "OpenSSH", also because another SSH client like PuTTY might be in use. So generalize wording and also say which parent process, i.e. Git, requires authentication. Signed-off-by: Sebastian Schuberth --- git-gui/git-gui--askpass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass index 4277f30..4e3f00d 100755 --- a/git-gui/git-gui--askpass +++ b/git-gui/git-gui--askpass @@ -2,7 +2,7 @@ # Tcl ignores the next line -*- tcl -*- \ exec wish "$0" -- "$@" -# This is a trivial implementation of an SSH_ASKPASS handler. +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler. # Git-gui uses this script if none are already configured. package require Tk @@ -12,7 +12,7 @@ set yesno 0 set rc 255 if {$argc < 1} { - set prompt "Enter your OpenSSH passphrase:" + set prompt "Enter your password / passphrase:" } else { set prompt [join $argv " "] if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} { @@ -60,7 +60,7 @@ proc finish {} { set ::rc 0 } -wm title . "OpenSSH" +wm title . "Git Authentication" tk::PlaceWindow . vwait rc exit $rc -- https://github.com/git/git/pull/195 ``` ## Sebastian Schuberth, 2017-04-27 09:19 Subject: Re: [PATCH v2] git-gui--askpass: generalize the wording Message-ID: URL: https://gitlist.dev/e/f318a3ab-930f-fa58-db3d-d28998371a86%40gmail.com In-Reply-To: <0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000@eu-west-1.amazonses.com> ``` + Pat On 2017-04-27 08:38, Sebastian Schuberth wrote: > git-gui--askpass is not only used for SSH authentication, but also for > HTTPS. In that context it is confusing to only rfer to "OpenSSH", also > because another SSH client like PuTTY might be in use. So generalize > wording and also say which parent process, i.e. Git, requires > authentication. > > Signed-off-by: Sebastian Schuberth > --- > git-gui/git-gui--askpass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass > index 4277f30..4e3f00d 100755 > --- a/git-gui/git-gui--askpass > +++ b/git-gui/git-gui--askpass > @@ -2,7 +2,7 @@ > # Tcl ignores the next line -*- tcl -*- \ > exec wish "$0" -- "$@" > > -# This is a trivial implementation of an SSH_ASKPASS handler. > +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler. > # Git-gui uses this script if none are already configured. > > package require Tk > @@ -12,7 +12,7 @@ set yesno 0 > set rc 255 > > if {$argc < 1} { > - set prompt "Enter your OpenSSH passphrase:" > + set prompt "Enter your password / passphrase:" > } else { > set prompt [join $argv " "] > if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} { > @@ -60,7 +60,7 @@ proc finish {} { > set ::rc 0 > } > > -wm title . "OpenSSH" > +wm title . "Git Authentication" > tk::PlaceWindow . > vwait rc > exit $rc > -- Sebastian Schuberth ``` ## Johannes Schindelin, 2017-04-27 14:02 Subject: Re: [PATCH v2] git-gui--askpass: generalize the wording Message-ID: URL: https://gitlist.dev/e/alpine.DEB.2.20.1704271601440.3480%40virtualbox In-Reply-To: ``` + Pat On Thu, 27 Apr 2017, Sebastian Schuberth wrote: > + Pat > > On 2017-04-27 08:38, Sebastian Schuberth wrote: > > > git-gui--askpass is not only used for SSH authentication, but also for > > HTTPS. In that context it is confusing to only rfer to "OpenSSH", also > > because another SSH client like PuTTY might be in use. So generalize > > wording and also say which parent process, i.e. Git, requires > > authentication. > > > > Signed-off-by: Sebastian Schuberth > > --- > > git-gui/git-gui--askpass | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass > > index 4277f30..4e3f00d 100755 > > --- a/git-gui/git-gui--askpass > > +++ b/git-gui/git-gui--askpass > > @@ -2,7 +2,7 @@ > > # Tcl ignores the next line -*- tcl -*- \ > > exec wish "$0" -- "$@" > > > > -# This is a trivial implementation of an SSH_ASKPASS handler. > > +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler. > > # Git-gui uses this script if none are already configured. > > > > package require Tk > > @@ -12,7 +12,7 @@ set yesno 0 > > set rc 255 > > > > if {$argc < 1} { > > - set prompt "Enter your OpenSSH passphrase:" > > + set prompt "Enter your password / passphrase:" > > } else { > > set prompt [join $argv " "] > > if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} { > > @@ -60,7 +60,7 @@ proc finish {} { > > set ::rc 0 > > } > > > > -wm title . "OpenSSH" > > +wm title . "Git Authentication" > > tk::PlaceWindow . > > vwait rc > > exit $rc > > > > > -- > Sebastian Schuberth > > > ```