threads / patch / 40923

patchref-filter: mark some file-local functions static

Subject: [PATCH] ref-filter: mark some file-local functions static

## tl;dr

2 messages between Dec 2, 2015 and Dec 3, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Dec 2, 2015, 20:02 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Karthik,

If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing' branch, could you please squash the relevant parts of this patch into yours.

Thanks!

ATB, Ramsay Jones

 ref-filter.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Show changes to ref-filter.c +5 −5
diff --git a/ref-filter.c b/ref-filter.c
index 08f43b7..036549b 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -79,14 +79,14 @@ static int match_atom_name(const char *name, const char *atom_name, const char *
 	return 1;
 }
 
-void color_atom_parser(struct used_atom *atom)
+static void color_atom_parser(struct used_atom *atom)
 {
 	match_atom_name(atom->str, "color", &atom->u.color);
 	if (!atom->u.color)
 		die(_("expected format: %%(color:<color>)"));
 }
 
-void remote_ref_atom_parser(struct used_atom *atom)
+static void remote_ref_atom_parser(struct used_atom *atom)
 {
 	const char *buf;
 
@@ -104,7 +104,7 @@ void remote_ref_atom_parser(struct used_atom *atom)
 		die(_("improper format entered align:%s"), buf);
 }
 
-void contents_atom_parser(struct used_atom *atom)
+static void contents_atom_parser(struct used_atom *atom)
 {
 	const char * buf;
 
@@ -127,7 +127,7 @@ void contents_atom_parser(struct used_atom *atom)
 		die(_("improper format entered contents:%s"), buf);
 }
 
-void objectname_atom_parser(struct used_atom *atom)
+static void objectname_atom_parser(struct used_atom *atom)
 {
 	const char * buf;
 
@@ -153,7 +153,7 @@ static align_type get_align_position(const char *type)
 	return -1;
 }
 
-void align_atom_parser(struct used_atom *atom)
+static void align_atom_parser(struct used_atom *atom)
 {
 	struct align *align = &atom->u.align;
 	const char *buf = NULL;
-- 
2.6.0
Karthik Nayak· Dec 3, 2015, 06:12 UTC · re: Ramsay Jones · lore

Re: [PATCH] ref-filter: mark some file-local functions static

Hello,

On Thu, Dec 3, 2015 at 1:32 AM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 11 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Karthik,
>
> If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing'
> branch, could you please squash the relevant parts of this patch into
> yours.
>
> Thanks!
Thanks, will squash this into the next version.

Regards, Karthik Nayak

← back to recent threads