# [PATCH] ref-filter: mark some file-local functions static 2 messages from 2015-12-02 to 2015-12-03. Participants: Ramsay Jones, Karthik Nayak. Thread: https://gitlist.dev/t/40923 ## Ramsay Jones, 2015-12-02 20:02 Subject: [PATCH] ref-filter: mark some file-local functions static Message-ID: <565F4E69.5050800@ramsayjones.plus.com> URL: https://gitlist.dev/e/565F4E69.5050800%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Karthik, If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing' branch, could you please squash the relevant parts of this patch into yours. Thanks! ATB, Ramsay Jones ref-filter.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 08f43b7..036549b 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -79,14 +79,14 @@ static int match_atom_name(const char *name, const char *atom_name, const char * return 1; } -void color_atom_parser(struct used_atom *atom) +static void color_atom_parser(struct used_atom *atom) { match_atom_name(atom->str, "color", &atom->u.color); if (!atom->u.color) die(_("expected format: %%(color:)")); } -void remote_ref_atom_parser(struct used_atom *atom) +static void remote_ref_atom_parser(struct used_atom *atom) { const char *buf; @@ -104,7 +104,7 @@ void remote_ref_atom_parser(struct used_atom *atom) die(_("improper format entered align:%s"), buf); } -void contents_atom_parser(struct used_atom *atom) +static void contents_atom_parser(struct used_atom *atom) { const char * buf; @@ -127,7 +127,7 @@ void contents_atom_parser(struct used_atom *atom) die(_("improper format entered contents:%s"), buf); } -void objectname_atom_parser(struct used_atom *atom) +static void objectname_atom_parser(struct used_atom *atom) { const char * buf; @@ -153,7 +153,7 @@ static align_type get_align_position(const char *type) return -1; } -void align_atom_parser(struct used_atom *atom) +static void align_atom_parser(struct used_atom *atom) { struct align *align = &atom->u.align; const char *buf = NULL; -- 2.6.0 ``` ## Karthik Nayak, 2015-12-03 06:12 Subject: Re: [PATCH] ref-filter: mark some file-local functions static Message-ID: URL: https://gitlist.dev/e/CAOLa%3DZTxihUu%2BkOacyia29i7xKAB2mG00hRGLyLvydWzNAY9XQ%40mail.gmail.com In-Reply-To: <565F4E69.5050800@ramsayjones.plus.com> ``` Hello, On Thu, Dec 3, 2015 at 1:32 AM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Karthik, > > If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing' > branch, could you please squash the relevant parts of this patch into > yours. > > Thanks! Thanks, will squash this into the next version. Regards, Karthik Nayak ```