{"thread":{"id":"40923","subject":"[PATCH] ref-filter: mark some file-local functions static","startedAt":"2015-12-02T20:02:49Z","lastAt":"2015-12-03T06:12:51Z","messageCount":2,"participants":["Ramsay Jones","Karthik Nayak"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273934","messageId":"565F4E69.5050800@ramsayjones.plus.com","threadId":"40923","inReplyTo":null,"subject":"[PATCH] ref-filter: mark some file-local functions static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2015-12-02T20:02:49Z","receivedAt":"2015-12-02T20:02:49Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Karthik,\n\nIf you need to re-roll the patches in your 'kn/ref-filter-atom-parsing'\nbranch, could you please squash the relevant parts of this patch into\nyours.\n\nThanks!\n\nATB,\nRamsay Jones\n\n ref-filter.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/ref-filter.c b/ref-filter.c\nindex 08f43b7..036549b 100644\n--- a/ref-filter.c\n+++ b/ref-filter.c\n@@ -79,14 +79,14 @@ static int match_atom_name(const char *name, const char *atom_name, const char *\n \treturn 1;\n }\n \n-void color_atom_parser(struct used_atom *atom)\n+static void color_atom_parser(struct used_atom *atom)\n {\n \tmatch_atom_name(atom->str, \"color\", &atom->u.color);\n \tif (!atom->u.color)\n \t\tdie(_(\"expected format: %%(color:<color>)\"));\n }\n \n-void remote_ref_atom_parser(struct used_atom *atom)\n+static void remote_ref_atom_parser(struct used_atom *atom)\n {\n \tconst char *buf;\n \n@@ -104,7 +104,7 @@ void remote_ref_atom_parser(struct used_atom *atom)\n \t\tdie(_(\"improper format entered align:%s\"), buf);\n }\n \n-void contents_atom_parser(struct used_atom *atom)\n+static void contents_atom_parser(struct used_atom *atom)\n {\n \tconst char * buf;\n \n@@ -127,7 +127,7 @@ void contents_atom_parser(struct used_atom *atom)\n \t\tdie(_(\"improper format entered contents:%s\"), buf);\n }\n \n-void objectname_atom_parser(struct used_atom *atom)\n+static void objectname_atom_parser(struct used_atom *atom)\n {\n \tconst char * buf;\n \n@@ -153,7 +153,7 @@ static align_type get_align_position(const char *type)\n \treturn -1;\n }\n \n-void align_atom_parser(struct used_atom *atom)\n+static void align_atom_parser(struct used_atom *atom)\n {\n \tstruct align *align = &atom->u.align;\n \tconst char *buf = NULL;\n-- \n2.6.0\n"},{"id":"273965","messageId":"CAOLa=ZTxihUu+kOacyia29i7xKAB2mG00hRGLyLvydWzNAY9XQ@mail.gmail.com","threadId":"40923","inReplyTo":"565F4E69.5050800@ramsayjones.plus.com","subject":"Re: [PATCH] ref-filter: mark some file-local functions static","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2015-12-03T06:12:51Z","receivedAt":"2015-12-03T06:12:51Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"Hello,\n\nOn Thu, Dec 3, 2015 at 1:32 AM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Karthik,\n>\n> If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing'\n> branch, could you please squash the relevant parts of this patch into\n> yours.\n>\n> Thanks!\n\nThanks, will squash this into the next version.\n\nRegards,\nKarthik Nayak\n"}]}