threads / patch / 40641

patchblame: fix option name in error message

Subject: [PATCH] blame: fix option name in error message

## tl;dr

2 messages between Oct 26, 2015 and Oct 26, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Max Kirillov· Oct 26, 2015, 05:29 UTC · lore
The option name used in blame's UI is `--reverse`.
Signed-off-by: Max Kirillov <max@max630.net>
---
 builtin/blame.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/blame.c +1 −1
diff --git a/builtin/blame.c b/builtin/blame.c
index 98b1810..f89bc9e 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2697,7 +2697,7 @@ parse_done:
 		sb.commits.compare = compare_commits_by_commit_date;
 	}
 	else if (contents_from)
-		die("--contents and --children do not blend well.");
+		die("--contents and --reverse do not blend well.");
 	else {
 		final_commit_name = prepare_initial(&sb);
 		sb.commits.compare = compare_commits_by_reverse_commit_date;
-- 
2.3.4.2801.g3d0809b
Junio C Hamano· Oct 26, 2015, 06:29 UTC · re: Max Kirillov · lore

Re: [PATCH] blame: fix option name in error message

Max Kirillov <max@max630.net> writes:
> The option name used in blame's UI is `--reverse`.
>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
;-)

It is surprising that nobody noticed this which was in the very original of --reverse. Thanks.

Show 16 quoted lines
>  builtin/blame.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 98b1810..f89bc9e 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -2697,7 +2697,7 @@ parse_done:
>  		sb.commits.compare = compare_commits_by_commit_date;
>  	}
>  	else if (contents_from)
> -		die("--contents and --children do not blend well.");
> +		die("--contents and --reverse do not blend well.");
>  	else {
>  		final_commit_name = prepare_initial(&sb);
>  		sb.commits.compare = compare_commits_by_reverse_commit_date;

← back to recent threads