git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame: fix option name in error message

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 26, 2015, 06:29 UTC
Message-ID
<xmqqa8r6jg6p.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1445837340-4333-1-git-send-email-max@max630.net>
Max Kirillov <max@max630.net> writes:
> The option name used in blame's UI is `--reverse`.
>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
;-)

It is surprising that nobody noticed this which was in the very original of --reverse. Thanks.

Show 16 quoted lines
>  builtin/blame.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 98b1810..f89bc9e 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -2697,7 +2697,7 @@ parse_done:
>  		sb.commits.compare = compare_commits_by_commit_date;
>  	}
>  	else if (contents_from)
> -		die("--contents and --children do not blend well.");
> +		die("--contents and --reverse do not blend well.");
>  	else {
>  		final_commit_name = prepare_initial(&sb);
>  		sb.commits.compare = compare_commits_by_reverse_commit_date;
Previous: Max Kirillov
Message 2 of 2 in “blame: fix option name in error message”
  1. blame: fix option name in error messageMax Kirillov, Oct 26, 2015
  2. Junio C HamanoOct 26, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.