{"thread":{"id":"40641","subject":"[PATCH] blame: fix option name in error message","startedAt":"2015-10-26T05:29:00Z","lastAt":"2015-10-26T06:29:34Z","messageCount":2,"participants":["Max Kirillov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"272222","messageId":"1445837340-4333-1-git-send-email-max@max630.net","threadId":"40641","inReplyTo":null,"subject":"[PATCH] blame: fix option name in error message","fromName":"Max Kirillov","fromEmail":"max@max630.net","sentAt":"2015-10-26T05:29:00Z","receivedAt":"2015-10-26T05:29:00Z","isPatch":true,"sender":{"key":"max@max630.net","avatar":"https://avatars.githubusercontent.com/u/381560?v=4"},"body":"The option name used in blame's UI is `--reverse`.\n\nSigned-off-by: Max Kirillov <max@max630.net>\n---\n builtin/blame.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/blame.c b/builtin/blame.c\nindex 98b1810..f89bc9e 100644\n--- a/builtin/blame.c\n+++ b/builtin/blame.c\n@@ -2697,7 +2697,7 @@ parse_done:\n \t\tsb.commits.compare = compare_commits_by_commit_date;\n \t}\n \telse if (contents_from)\n-\t\tdie(\"--contents and --children do not blend well.\");\n+\t\tdie(\"--contents and --reverse do not blend well.\");\n \telse {\n \t\tfinal_commit_name = prepare_initial(&sb);\n \t\tsb.commits.compare = compare_commits_by_reverse_commit_date;\n-- \n2.3.4.2801.g3d0809b\n"},{"id":"272227","messageId":"xmqqa8r6jg6p.fsf@gitster.mtv.corp.google.com","threadId":"40641","inReplyTo":"1445837340-4333-1-git-send-email-max@max630.net","subject":"Re: [PATCH] blame: fix option name in error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-26T06:29:34Z","receivedAt":"2015-10-26T06:29:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Max Kirillov <max@max630.net> writes:\n\n> The option name used in blame's UI is `--reverse`.\n>\n> Signed-off-by: Max Kirillov <max@max630.net>\n> ---\n\n;-)\n\nIt is surprising that nobody noticed this which was in the very\noriginal of --reverse.  Thanks.\n\n>  builtin/blame.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/blame.c b/builtin/blame.c\n> index 98b1810..f89bc9e 100644\n> --- a/builtin/blame.c\n> +++ b/builtin/blame.c\n> @@ -2697,7 +2697,7 @@ parse_done:\n>  \t\tsb.commits.compare = compare_commits_by_commit_date;\n>  \t}\n>  \telse if (contents_from)\n> -\t\tdie(\"--contents and --children do not blend well.\");\n> +\t\tdie(\"--contents and --reverse do not blend well.\");\n>  \telse {\n>  \t\tfinal_commit_name = prepare_initial(&sb);\n>  \t\tsb.commits.compare = compare_commits_by_reverse_commit_date;\n"}]}